| Message ID | 1370056054-25449-5-git-send-email-jlayton@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, May 31, 2013 at 11:07:27PM -0400, Jeff Layton wrote: > ...save 3 bytes of stack space. > > Signed-off-by: Jeff Layton <jlayton@redhat.com> ACK.--b. > --- > fs/locks.c | 9 +++++---- > 1 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/fs/locks.c b/fs/locks.c > index a7d2253..cef0e04 100644 > --- a/fs/locks.c > +++ b/fs/locks.c > @@ -800,7 +800,8 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str > struct file_lock *left = NULL; > struct file_lock *right = NULL; > struct file_lock **before; > - int error, added = 0; > + int error; > + bool added = false; > > /* > * We may need two file_lock structures for this operation, > @@ -894,7 +895,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str > continue; > } > request = fl; > - added = 1; > + added = true; > } > else { > /* Processing for different lock types is a bit > @@ -905,7 +906,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str > if (fl->fl_start > request->fl_end) > break; > if (request->fl_type == F_UNLCK) > - added = 1; > + added = true; > if (fl->fl_start < request->fl_start) > left = fl; > /* If the next lock in the list has a higher end > @@ -935,7 +936,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str > locks_release_private(fl); > locks_copy_private(fl, request); > request = fl; > - added = 1; > + added = true; > } > } > /* Go on to next lock. > -- > 1.7.1 > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/locks.c b/fs/locks.c index a7d2253..cef0e04 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -800,7 +800,8 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str struct file_lock *left = NULL; struct file_lock *right = NULL; struct file_lock **before; - int error, added = 0; + int error; + bool added = false; /* * We may need two file_lock structures for this operation, @@ -894,7 +895,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str continue; } request = fl; - added = 1; + added = true; } else { /* Processing for different lock types is a bit @@ -905,7 +906,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str if (fl->fl_start > request->fl_end) break; if (request->fl_type == F_UNLCK) - added = 1; + added = true; if (fl->fl_start < request->fl_start) left = fl; /* If the next lock in the list has a higher end @@ -935,7 +936,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str locks_release_private(fl); locks_copy_private(fl, request); request = fl; - added = 1; + added = true; } } /* Go on to next lock.
...save 3 bytes of stack space. Signed-off-by: Jeff Layton <jlayton@redhat.com> --- fs/locks.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)