diff mbox

rbd: fix ida/idr memory leak

Message ID 1401899917-11254-1-git-send-email-ilya.dryomov@inktank.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ilya Dryomov June 4, 2014, 4:38 p.m. UTC 
ida_destroy() needs to be called on module exit to release ida caches.

Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
---
 drivers/block/rbd.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Alex Elder June 4, 2014, 5:01 p.m. UTC | #1 
On 06/04/2014 11:38 AM, Ilya Dryomov wrote:
> ida_destroy() needs to be called on module exit to release ida caches.

Looks good to me.

Reviewed-by: Alex Elder <elder@linaro.org>

> Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
> ---
>  drivers/block/rbd.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 94747afc2e78..ecdd4aee173c 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -5464,6 +5464,7 @@ err_out_slab:
>  
>  static void __exit rbd_exit(void)
>  {
> +	ida_destroy(&rbd_dev_id_ida);
>  	rbd_sysfs_cleanup();
>  	if (single_major)
>  		unregister_blkdev(rbd_major, RBD_DRV_NAME);
> 

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 94747afc2e78..ecdd4aee173c 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -5464,6 +5464,7 @@  err_out_slab:
 
 static void __exit rbd_exit(void)
 {
+	ida_destroy(&rbd_dev_id_ida);
 	rbd_sysfs_cleanup();
 	if (single_major)
 		unregister_blkdev(rbd_major, RBD_DRV_NAME);