| Message ID | 1406191369-6746-4-git-send-email-ilya.dryomov@inktank.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/24/2014 03:42 AM, Ilya Dryomov wrote: > spec->image_id assert doesn't buy us much and image_format is asserted > in rbd_dev_header_name() and rbd_dev_header_info() anyway. Looks good. Over time I'm sure there are more assertions that can go away; they were most useful during rapid development when confidence in certain things was lower. Reviewed-by: Alex Elder <elder@linaro.org> > > Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com> > --- > drivers/block/rbd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index 0d3be608f16f..4541f6027e4a 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -5143,8 +5143,6 @@ static int rbd_dev_image_probe(struct rbd_device *rbd_dev, bool mapping) > ret = rbd_dev_image_id(rbd_dev); > if (ret) > return ret; > - rbd_assert(rbd_dev->spec->image_id); > - rbd_assert(rbd_image_format_valid(rbd_dev->image_format)); > > ret = rbd_dev_header_name(rbd_dev); > if (ret) > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 0d3be608f16f..4541f6027e4a 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -5143,8 +5143,6 @@ static int rbd_dev_image_probe(struct rbd_device *rbd_dev, bool mapping) ret = rbd_dev_image_id(rbd_dev); if (ret) return ret; - rbd_assert(rbd_dev->spec->image_id); - rbd_assert(rbd_image_format_valid(rbd_dev->image_format)); ret = rbd_dev_header_name(rbd_dev); if (ret)
spec->image_id assert doesn't buy us much and image_format is asserted in rbd_dev_header_name() and rbd_dev_header_info() anyway. Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com> --- drivers/block/rbd.c | 2 -- 1 file changed, 2 deletions(-)