| Message ID | 1406280385-30275-1-git-send-email-ilya.dryomov@inktank.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/25/2014 04:26 AM, Ilya Dryomov wrote: > struct ceph_xattr -> struct ceph_inode_xattr Looks good. I can't find the definition of ceph_xattr. Reviewed-by: Alex Elder <elder@linaro.org> > Reported-by: Toralf Förster <toralf.foerster@gmx.de> > Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com> > --- > fs/ceph/xattr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c > index f89698cdbc41..12f58d22e017 100644 > --- a/fs/ceph/xattr.c > +++ b/fs/ceph/xattr.c > @@ -592,7 +592,7 @@ start: > xattr_version = ci->i_xattrs.version; > spin_unlock(&ci->i_ceph_lock); > > - xattrs = kcalloc(numattr, sizeof(struct ceph_xattr *), > + xattrs = kcalloc(numattr, sizeof(struct ceph_inode_xattr *), > GFP_NOFS); > err = -ENOMEM; > if (!xattrs) > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 25, 2014 at 4:52 PM, Alex Elder <elder@ieee.org> wrote: > On 07/25/2014 04:26 AM, Ilya Dryomov wrote: >> struct ceph_xattr -> struct ceph_inode_xattr > > Looks good. I can't find the definition of ceph_xattr. That's the point of the patch ;) Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/25/2014 08:27 AM, Ilya Dryomov wrote: > On Fri, Jul 25, 2014 at 4:52 PM, Alex Elder <elder@ieee.org> wrote: >> On 07/25/2014 04:26 AM, Ilya Dryomov wrote: >>> struct ceph_xattr -> struct ceph_inode_xattr >> >> Looks good. I can't find the definition of ceph_xattr. > > That's the point of the patch ;) Well, I thought the point was that the type was wrong; I was surprised that the type was non-existent. -Alex > Thanks, > > Ilya > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c index f89698cdbc41..12f58d22e017 100644 --- a/fs/ceph/xattr.c +++ b/fs/ceph/xattr.c @@ -592,7 +592,7 @@ start: xattr_version = ci->i_xattrs.version; spin_unlock(&ci->i_ceph_lock); - xattrs = kcalloc(numattr, sizeof(struct ceph_xattr *), + xattrs = kcalloc(numattr, sizeof(struct ceph_inode_xattr *), GFP_NOFS); err = -ENOMEM; if (!xattrs)
struct ceph_xattr -> struct ceph_inode_xattr Reported-by: Toralf Förster <toralf.foerster@gmx.de> Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com> --- fs/ceph/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)