| Message ID | 1455986729-12544-4-git-send-email-idryomov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/20/2016 10:45 AM, Ilya Dryomov wrote: > Commit d15f9d694b77 ("libceph: check data_len in ->alloc_msg()") > mistakenly bumped the log level on the "tid %llu unknown, skipping" > message. Turn it back into a dout() - stray replies are perfectly > normal when OSDs flap, crash, get killed for testing purposes, etc. > > Cc: stable@vger.kernel.org # 4.3+ > Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Looks good. Reviewed-by: Alex Elder <elder@linaro.org> > --- > net/ceph/osd_client.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c > index 7c1a5d1734c3..32355d9d0103 100644 > --- a/net/ceph/osd_client.c > +++ b/net/ceph/osd_client.c > @@ -2890,8 +2890,8 @@ static struct ceph_msg *get_reply(struct ceph_connection *con, > mutex_lock(&osdc->request_mutex); > req = __lookup_request(osdc, tid); > if (!req) { > - pr_warn("%s osd%d tid %llu unknown, skipping\n", > - __func__, osd->o_osd, tid); > + dout("%s osd%d tid %llu unknown, skipping\n", __func__, > + osd->o_osd, tid); > m = NULL; > *skip = 1; > goto out; > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c index 7c1a5d1734c3..32355d9d0103 100644 --- a/net/ceph/osd_client.c +++ b/net/ceph/osd_client.c @@ -2890,8 +2890,8 @@ static struct ceph_msg *get_reply(struct ceph_connection *con, mutex_lock(&osdc->request_mutex); req = __lookup_request(osdc, tid); if (!req) { - pr_warn("%s osd%d tid %llu unknown, skipping\n", - __func__, osd->o_osd, tid); + dout("%s osd%d tid %llu unknown, skipping\n", __func__, + osd->o_osd, tid); m = NULL; *skip = 1; goto out;
Commit d15f9d694b77 ("libceph: check data_len in ->alloc_msg()") mistakenly bumped the log level on the "tid %llu unknown, skipping" message. Turn it back into a dout() - stray replies are perfectly normal when OSDs flap, crash, get killed for testing purposes, etc. Cc: stable@vger.kernel.org # 4.3+ Signed-off-by: Ilya Dryomov <idryomov@gmail.com> --- net/ceph/osd_client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)