| Message ID | 1478259273-3471-4-git-send-email-jlayton@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c index ef4d04647325..f03dc579e0ec 100644 --- a/fs/ceph/inode.c +++ b/fs/ceph/inode.c @@ -514,6 +514,8 @@ struct inode *ceph_alloc_inode(struct super_block *sb) ceph_fscache_inode_init(ci); + // FIXME: merge initialization into inode_init_always ? + ci->vfs_inode.i_version = 0; return &ci->vfs_inode; }
Currently, i_version is not always initialized when inodes are allocated, so it's possible to end up "inheriting" an i_version from a completely different inode. In most cases, this is not an issue, as the initialized value will end up being clobbered when the inode metadata is set up. Ceph is a little different here though as we always want the max value for i_version. For now, just initialize this to 0 in ceph_alloc_inode, but we may eventually want to move this into inode_init_always and do it for all filesystems. Signed-off-by: Jeff Layton <jlayton@redhat.com> --- fs/ceph/inode.c | 2 ++ 1 file changed, 2 insertions(+)