From patchwork Fri Nov 4 11:34:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 9412529 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C9FB160723 for ; Fri, 4 Nov 2016 11:34:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BEFCE2ADB4 for ; Fri, 4 Nov 2016 11:34:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B36AF2ADBB; Fri, 4 Nov 2016 11:34:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5ED572ADB4 for ; Fri, 4 Nov 2016 11:34:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761464AbcKDLej (ORCPT ); Fri, 4 Nov 2016 07:34:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52690 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761180AbcKDLeh (ORCPT ); Fri, 4 Nov 2016 07:34:37 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 41DBB61BA9; Fri, 4 Nov 2016 11:34:37 +0000 (UTC) Received: from tlielax.poochiereds.net (ovpn-116-47.rdu2.redhat.com [10.10.116.47]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA4BYXuO000712; Fri, 4 Nov 2016 07:34:36 -0400 From: Jeff Layton To: ceph-devel@vger.kernel.org Cc: idryomov@gmail.com, zyan@redhat.com, sage@redhat.com Subject: [RFC PATCH 03/10] ceph: initialize i_version to 0 in new ceph inodes Date: Fri, 4 Nov 2016 07:34:26 -0400 Message-Id: <1478259273-3471-4-git-send-email-jlayton@redhat.com> In-Reply-To: <1478259273-3471-1-git-send-email-jlayton@redhat.com> References: <1478259273-3471-1-git-send-email-jlayton@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 04 Nov 2016 11:34:37 +0000 (UTC) Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently, i_version is not always initialized when inodes are allocated, so it's possible to end up "inheriting" an i_version from a completely different inode. In most cases, this is not an issue, as the initialized value will end up being clobbered when the inode metadata is set up. Ceph is a little different here though as we always want the max value for i_version. For now, just initialize this to 0 in ceph_alloc_inode, but we may eventually want to move this into inode_init_always and do it for all filesystems. Signed-off-by: Jeff Layton --- fs/ceph/inode.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c index ef4d04647325..f03dc579e0ec 100644 --- a/fs/ceph/inode.c +++ b/fs/ceph/inode.c @@ -514,6 +514,8 @@ struct inode *ceph_alloc_inode(struct super_block *sb) ceph_fscache_inode_init(ci); + // FIXME: merge initialization into inode_init_always ? + ci->vfs_inode.i_version = 0; return &ci->vfs_inode; }