From patchwork Mon Nov 13 10:50:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Dryomov X-Patchwork-Id: 10055591 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 85ECD60586 for ; Mon, 13 Nov 2017 10:50:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA41828F86 for ; Mon, 13 Nov 2017 10:50:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9C44729113; Mon, 13 Nov 2017 10:50:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4448C28F86 for ; Mon, 13 Nov 2017 10:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752426AbdKMKuo (ORCPT ); Mon, 13 Nov 2017 05:50:44 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:47981 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752418AbdKMKun (ORCPT ); Mon, 13 Nov 2017 05:50:43 -0500 Received: by mail-wr0-f193.google.com with SMTP id k61so14007340wrc.4 for ; Mon, 13 Nov 2017 02:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=bU72THorDDmKIPCHd2ZvQ/TL7Yt0a9K3Hwpw5gVjsVs=; b=GxAspb93usoxA8NcIWV5CYiWIKuXlTQfI+2AjI638vKUqqlC2ajSTfFyGaYU6vyUF5 bx0BOpMt/hpH3XJW7IUH7tZwnYZ8R1/iDBgGGsGZc1YeEhYgISG8DAnqwUPBCn3Ao+eJ 1G9A3aTO6StZA5bHdC4DyQ1bvomNCUn5SvURqIUVGf8mHl9nVa0tDcCVN0EryJufjusv 0868v1noTFrwII1rEYvvZnr0wPZdXfMKr2Jza9p1CiPPG08lK1A8yyZt7nOjLB/5YPEr TiLq3eTnoAV9NblR1WwFGENcJ2lGUbnERq7sIl4UilZM66Hyq3x6fSHoGKq7hfMS4orm SuuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bU72THorDDmKIPCHd2ZvQ/TL7Yt0a9K3Hwpw5gVjsVs=; b=uExk22oovZK07MReUIpJdn+CaH6OqVduLb7ftELhQHw5CemI52z+Dx9Bc4DcuqFG+G FvzcrrF0yhOI7+sSzmdK9KnDyv1dnNu5jvonH8YbkedoyF22CUpXDC/BBvv6XUtQOmc3 bWuGspJkh8pLnqLxlE04UGBFT+KaH8A5Hb6pmJgwPMGNwPvahHQNsSy1oIXfeRpBWsjo ek9qToFeuUIwrNbeuBrwcY7PNX+L393sT1BKAtgOfEqAjDLTGCogt/l/lpIwp7NFZHtB 2E+UiVWY4voum2E12hJfYyO9D/W4JD8IYByZ8w2Kv5Uh3zNYuDPI4HhIrvkFKrCOveVK KHbw== X-Gm-Message-State: AJaThX5mAgeG6pysivpcaPZpNEJcg4d167BnMP/5wNrKlc6ElKxDd/p8 BaehJ8zodOfpUiwjDpszxxG/j0+b X-Google-Smtp-Source: AGs4zMbVFHgFhVLtE3xQPwy5SfrclBj6sEC9QVc7khhk0uceicxxJJKXO7LP0RQtNdXYjCk+AWDAyg== X-Received: by 10.223.130.225 with SMTP id 88mr6867802wrc.6.1510570242035; Mon, 13 Nov 2017 02:50:42 -0800 (PST) Received: from orange.local (ip-62-245-115-99.net.upcbroadband.cz. [62.245.115.99]) by smtp.gmail.com with ESMTPSA id v198sm2481343wmv.4.2017.11.13.02.50.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Nov 2017 02:50:41 -0800 (PST) From: Ilya Dryomov To: ceph-devel@vger.kernel.org Cc: Sage Weil Subject: [PATCH] rbd: default to single-major device number scheme Date: Mon, 13 Nov 2017 11:50:17 +0100 Message-Id: <1510570217-14811-1-git-send-email-idryomov@gmail.com> X-Mailer: git-send-email 2.4.3 Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It's been 3.5 years, let's turn it on by default. Support in rbd(8) utility goes back to pre-firefly, "rbd map" has been loading the module with single_major=Y ever since. However, if the module is already loaded (whether by hand or at boot time), we end up with single_major=N. Also, some people don't install rbd(8) and use the sysfs interface directly. (With single-major=N, a major number is consumed for every mapping, imposing a limit of ~240 rbd images per host. single-major=Y allows mapping thousands of rbd images on a single machine.) Signed-off-by: Ilya Dryomov Reviewed-by: Jason Dillaman --- drivers/block/rbd.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 57275298d9fc..f40050c97bb3 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -449,12 +449,11 @@ static DEFINE_IDA(rbd_dev_id_ida); static struct workqueue_struct *rbd_wq; /* - * Default to false for now, as single-major requires >= 0.75 version of - * userspace rbd utility. + * single-major requires >= 0.75 version of userspace rbd utility. */ -static bool single_major = false; +static bool single_major = true; module_param(single_major, bool, S_IRUGO); -MODULE_PARM_DESC(single_major, "Use a single major number for all rbd devices (default: false)"); +MODULE_PARM_DESC(single_major, "Use a single major number for all rbd devices (default: true)"); static int rbd_img_request_submit(struct rbd_img_request *img_request);