| Message ID | 1518680345-17700-1-git-send-email-cgxu519@icloud.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Feb 15, 2018 at 8:39 AM, Chengguang Xu <cgxu519@icloud.com> wrote: > Using seq_show_option to replace seq_printf for string type options. > > Signed-off-by: Chengguang Xu <cgxu519@icloud.com> > --- > Changes since v1: > - Code cleanup for showing fscache related options. > > fs/ceph/super.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/ceph/super.c b/fs/ceph/super.c > index a62d2a9..f9418d4 100644 > --- a/fs/ceph/super.c > +++ b/fs/ceph/super.c > @@ -511,10 +511,7 @@ static int ceph_show_options(struct seq_file *m, struct dentry *root) > if ((fsopt->flags & CEPH_MOUNT_OPT_DCACHE) == 0) > seq_puts(m, ",nodcache"); > if (fsopt->flags & CEPH_MOUNT_OPT_FSCACHE) { > - if (fsopt->fscache_uniq) > - seq_printf(m, ",fsc=%s", fsopt->fscache_uniq); > - else > - seq_puts(m, ",fsc"); > + seq_show_option(m, "fsc", fsopt->fscache_uniq); > } > if (fsopt->flags & CEPH_MOUNT_OPT_NOPOOLPERM) > seq_puts(m, ",nopoolperm"); > @@ -527,7 +524,7 @@ static int ceph_show_options(struct seq_file *m, struct dentry *root) > #endif > > if (fsopt->mds_namespace) > - seq_printf(m, ",mds_namespace=%s", fsopt->mds_namespace); > + seq_show_option(m, "mds_namespace", fsopt->mds_namespace); > if (fsopt->wsize) > seq_printf(m, ",wsize=%d", fsopt->wsize); > if (fsopt->rsize != CEPH_MAX_READ_SIZE) Applied. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ceph/super.c b/fs/ceph/super.c index a62d2a9..f9418d4 100644 --- a/fs/ceph/super.c +++ b/fs/ceph/super.c @@ -511,10 +511,7 @@ static int ceph_show_options(struct seq_file *m, struct dentry *root) if ((fsopt->flags & CEPH_MOUNT_OPT_DCACHE) == 0) seq_puts(m, ",nodcache"); if (fsopt->flags & CEPH_MOUNT_OPT_FSCACHE) { - if (fsopt->fscache_uniq) - seq_printf(m, ",fsc=%s", fsopt->fscache_uniq); - else - seq_puts(m, ",fsc"); + seq_show_option(m, "fsc", fsopt->fscache_uniq); } if (fsopt->flags & CEPH_MOUNT_OPT_NOPOOLPERM) seq_puts(m, ",nopoolperm"); @@ -527,7 +524,7 @@ static int ceph_show_options(struct seq_file *m, struct dentry *root) #endif if (fsopt->mds_namespace) - seq_printf(m, ",mds_namespace=%s", fsopt->mds_namespace); + seq_show_option(m, "mds_namespace", fsopt->mds_namespace); if (fsopt->wsize) seq_printf(m, ",wsize=%d", fsopt->wsize); if (fsopt->rsize != CEPH_MAX_READ_SIZE)
Using seq_show_option to replace seq_printf for string type options. Signed-off-by: Chengguang Xu <cgxu519@icloud.com> --- Changes since v1: - Code cleanup for showing fscache related options. fs/ceph/super.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)