From patchwork Tue Mar 13 02:43:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 10277731 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D13E7601A0 for ; Tue, 13 Mar 2018 02:44:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA2B328B9A for ; Tue, 13 Mar 2018 02:44:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BEDFB28BAA; Tue, 13 Mar 2018 02:44:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7101328B9A for ; Tue, 13 Mar 2018 02:44:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932289AbeCMCoL (ORCPT ); Mon, 12 Mar 2018 22:44:11 -0400 Received: from mout.gmx.net ([212.227.15.15]:46585 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932242AbeCMCoK (ORCPT ); Mon, 12 Mar 2018 22:44:10 -0400 Received: from juanniu018037.ss.mogujie.org ([122.225.81.134]) by mail.gmx.com (mrgmx001 [212.227.17.184]) with ESMTPSA (Nemesis) id 0MH07e-1eqZhH0xww-00Drnx; Tue, 13 Mar 2018 03:44:06 +0100 From: Chengguang Xu To: zyan@redhat.com, idryomov@gmail.com Cc: ceph-devel@vger.kernel.org, Chengguang Xu Subject: [PATCH] ceph: return proper bool type to caller instead of pointer Date: Tue, 13 Mar 2018 10:43:45 +0800 Message-Id: <1520909025-70638-1-git-send-email-cgxu519@gmx.com> X-Mailer: git-send-email 1.8.3.1 X-Provags-ID: V03:K0:aClxB/eUJ5YITz68dIIvCyJdXrnOxz3FTGT3DjC6SXcqVqymsGH 4IxMC2Y/eXdpmN0GB0MSEXkF/LPG/K4VAbH/BJbUnMgyPeFMti04YpCn3hxdstJkjOVXVMU GZNuCF1RNhKXAOh97auONCv1pAbwUA5HKBcsg9AazhZolJGPZShvHEhA2O8Q/7QQ3spfoya TQNg5akpJ0XnqeD4gw/1w== X-UI-Out-Filterresults: notjunk:1; V01:K0:JacfpgS4+I8=:Qk+eGxTkrFH4HCbcjbAtXh RTt/3vHwhhIgnXa2iveqRDqch+fAvT2EK9dy6Qt9bFmj1e2GL5wQBX1q8/uN1boEN0qfqt0xH WVfjmOezW1jvFGQ9tTSlh83O0+fYY0WqqOLl2ZKn9zfkt+fPCIFDN4TAy7aZ1ia33x7ACaEyp uhIVvsU/guP+Lxx2rGXj5r9I8dyvHGRFCjrWNSI0imOajpK2aSmAa7HnLfN5JFP8yZ00tr20J wVrJ64OOux86DIxio0CYGYdYVE//NctW+PLvUD4ztLEfVXrJRGPQ2rUfe7M60cnrisRNW6kCz Jrvf8ZrJ7qIBib63go7pAOppX2KMvlx8c9QD5KJkmPaF8wQm41fW5vOv125xK756XTtvKXxdO 7je21fcO/ZuhNnPPsbuiV0RbU284ps+wCLIu214o0B5buHTqlLXosjk/4ME0MDr5NFwRscQr4 qHQmxdmdHnbrtXjq2xgZCaN0O0MOThpLL5hRHG1CpW7KbzIxbUlQ1hv2tcDawxTE12FXk8M29 qIdl0ozfjaf+3wKJQ7bbZQkakBVIhEgMp34z3m1vXx0bDYxD7W5zoROM4jWhpdV5isLIn5Esp 3aCGb6YOUUpJRRMl2nohQPGEF6tfET6GAKgyBbU1CudSNoFahu7t+sm6LPVvfvXGYuB9xqN96 5sEGLaIVKTkeCRu9q2sNGZpRsFouiuvXm+33w6BN4hiOgqfhzWjbjIAHX7S45SDUSyST07eh9 Dc6oxaoka9qfcg+F9nC9RZrjOGFLBpQ3aHNNTI/hygXauQ0MaQfVisIhZKpyoJ2vMKSsbZlyO dslXvW+GbF1EuPdAkAok4QDVzwX1w== Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Change to return true/false only for bool type return code. Signed-off-by: Chengguang Xu --- fs/ceph/mds_client.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c index e932c06..70d696b 100644 --- a/fs/ceph/mds_client.c +++ b/fs/ceph/mds_client.c @@ -439,9 +439,10 @@ struct ceph_mds_session *__ceph_lookup_mds_session(struct ceph_mds_client *mdsc, static bool __have_session(struct ceph_mds_client *mdsc, int mds) { - if (mds >= mdsc->max_sessions) + if (mds >= mdsc->max_sessions || !mdsc->sessions[mds]) return false; - return mdsc->sessions[mds]; + else + return true; } static int __verify_registered_session(struct ceph_mds_client *mdsc,