From patchwork Wed Apr 4 09:49:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10322321 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9A01560318 for ; Wed, 4 Apr 2018 09:49:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 80C2F28C80 for ; Wed, 4 Apr 2018 09:49:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 73C7928DBE; Wed, 4 Apr 2018 09:49:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E3E1428C80 for ; Wed, 4 Apr 2018 09:49:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750908AbeDDJto (ORCPT ); Wed, 4 Apr 2018 05:49:44 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:39525 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750814AbeDDJtm (ORCPT ); Wed, 4 Apr 2018 05:49:42 -0400 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id 0McPxo-1em8C43JKq-00HfVm; Wed, 04 Apr 2018 11:49:32 +0200 From: Arnd Bergmann To: Ilya Dryomov , Sage Weil , Alex Elder , Jens Axboe Cc: Arnd Bergmann , Jason Dillaman , ceph-devel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] rbd: add missing return statements Date: Wed, 4 Apr 2018 11:49:22 +0200 Message-Id: <20180404094931.2345742-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:2eqiCP0PnfsWewcUKSn2SCTy+DnBjobuJ/6VtkV4fL3opH2PuLn UgWodwMlMAmUymrqlrTwko3y1ThJhtvmnrJLcr/zgSCRMn5iljxc86I7Wh10hWydh7sQ06D cXZKgZfGqkYjW+c7YIGgL6Djf1jU7VIDw8s/XQgXJiOjajEI7XHa4tsVQ6GrgW6+mngIyzC 6XF2+VLe1vHhHlu9qiUPA== X-UI-Out-Filterresults: notjunk:1; V01:K0:2nZUGX+MFWo=:/DUhrwuR6joHieZ/Okh83N rDTMV62CpRjg+ZcL5Nsqwg54f12SFjd8+Y8vtakKsyt5OY8YuhHeMZ/LAFmHvpeb2qI/AvC7X u1RQH5Em731vU/H++eecubQr+6yPxpMwtkNxq/cd1C196AgCFlpVN1/7NpemmDwB7W88+HiH5 TZI92BgqJi98SQEEyGIIT+a3P1peyADiwvDND3BtkiQa8fg+WVFuWfGusU3Q7Zk6wVuZYWDxt usARohLvdX+pj5xhtEMw2FwjkNbhuVEOPvQqLwGbjaWO8UBAYFRXL0/iPpiyN5Afl6EmjMjEH ltW5qhQfXVoi+ppNi3xKyLuQBTgghXUUdNeMBvr3V0NDcVYIESjuQZ2+V3UIQMiigGIxIr0YE vyoHnhwoK6XIkPKB0OUUM1HisCcOEC7Y38pLZzOasBQTSrAc9o3riXTDjdJBzDkr4V+8KhB/e nYrZW8SUVCF6pqa5cJJM5KqikQAujZZ7EA9PMJZ/WJtXLpV2IV95ALuvbAjZdqaMyYrJ+NGE6 1eNkt8cs0sgRGOV1h6I8jJjL0PpLFj5mQi0N6YcGYojdc6mwTw58/Ve7bLr3mCCyYT3UZwbKx 10h2g7S2j10g06JA+sjWxt0BD0lKRle4byFF+ACUIKB2Fzv4AfOd8Uc/fAvlbrt+lEueHnbFP X3TyDSmmShHGEULakvY0k/ouTHTXmUC5gxpCjLlsHKxcM+qk4Tu66xuWbgdCrbFmkj8b2b8X2 qWXxqHUGoClHAEOiVIx3ZI/eVnieBJMWwuSzKA== Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A new set of warnings appeared in next-20180403 in some configurations when gcc cannot see that rbd_assert(0) leads to an unreachable code path: drivers/block/rbd.c: In function 'rbd_img_is_write': drivers/block/rbd.c:1397:1: error: control reaches end of non-void function [-Werror=return-type] drivers/block/rbd.c: In function '__rbd_obj_handle_request': drivers/block/rbd.c:2499:1: error: control reaches end of non-void function [-Werror=return-type] drivers/block/rbd.c: In function 'rbd_obj_handle_write': drivers/block/rbd.c:2471:1: error: control reaches end of non-void function [-Werror=return-type] To work around this, we can add a return statement to each of these cases. An alternative would be to remove the unlikely() annotation in rbd_assert(), or to just use BUG()/BUG_ON() directly. This adds the return statements, guessing what the most reasonable behavior would be. Fixes: 3da691bf4366 ("rbd: new request handling code") Signed-off-by: Arnd Bergmann --- drivers/block/rbd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 07dc5419bd63..9445a71a9cd6 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -1394,6 +1394,7 @@ static bool rbd_img_is_write(struct rbd_img_request *img_req) default: rbd_assert(0); } + return false; } static void rbd_obj_handle_request(struct rbd_obj_request *obj_req); @@ -2468,6 +2469,7 @@ static bool rbd_obj_handle_write(struct rbd_obj_request *obj_req) default: rbd_assert(0); } + return true; } /* @@ -2496,6 +2498,7 @@ static bool __rbd_obj_handle_request(struct rbd_obj_request *obj_req) default: rbd_assert(0); } + return true; } static void rbd_obj_end_request(struct rbd_obj_request *obj_req)