| Message ID | 20230417024134.30560-1-xiubli@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | common/rc: skip ceph when atime is required | expand |
On Mon, Apr 17, 2023 at 10:41:34AM +0800, xiubli@redhat.com wrote: > From: Xiubo Li <xiubli@redhat.com> > > Ceph won't maintain the atime, so just skip the tests when the atime > is required. > > URL: https://tracker.ceph.com/issues/53844 > Signed-off-by: Xiubo Li <xiubli@redhat.com> > --- > common/rc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/common/rc b/common/rc > index 90749343..3238842e 100644 > --- a/common/rc > +++ b/common/rc > @@ -3999,6 +3999,9 @@ _require_atime() > nfs|cifs|virtiofs) > _notrun "atime related mount options have no effect on $FSTYP" > ;; > + ceph) > + _notrun "atime not maintained by $FSTYP" Make sense to me. I'll change this line a bit when I merge it, to keep the line aligned (with above). Reviewed-by: Zorro Lang <zlang@redhat.com> Thanks, Zorro > + ;; > esac > > } > -- > 2.39.1 >
On 4/17/23 12:17, Zorro Lang wrote: > On Mon, Apr 17, 2023 at 10:41:34AM +0800, xiubli@redhat.com wrote: >> From: Xiubo Li <xiubli@redhat.com> >> >> Ceph won't maintain the atime, so just skip the tests when the atime >> is required. >> >> URL: https://tracker.ceph.com/issues/53844 >> Signed-off-by: Xiubo Li <xiubli@redhat.com> >> --- >> common/rc | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/common/rc b/common/rc >> index 90749343..3238842e 100644 >> --- a/common/rc >> +++ b/common/rc >> @@ -3999,6 +3999,9 @@ _require_atime() >> nfs|cifs|virtiofs) >> _notrun "atime related mount options have no effect on $FSTYP" >> ;; >> + ceph) >> + _notrun "atime not maintained by $FSTYP" > Make sense to me. I'll change this line a bit when I merge it, to keep the line > aligned (with above). > > Reviewed-by: Zorro Lang <zlang@redhat.com> Sure, thanks Zorro. - Xiubo > Thanks, > Zorro > >> + ;; >> esac >> >> } >> -- >> 2.39.1 >>
diff --git a/common/rc b/common/rc index 90749343..3238842e 100644 --- a/common/rc +++ b/common/rc @@ -3999,6 +3999,9 @@ _require_atime() nfs|cifs|virtiofs) _notrun "atime related mount options have no effect on $FSTYP" ;; + ceph) + _notrun "atime not maintained by $FSTYP" + ;; esac }