diff mbox series

ceph: add process/thread ID into debug output

Message ID 20250206191126.137262-1-slava@dubeyko.com (mailing list archive)
State New
Headers show
Series ceph: add process/thread ID into debug output | expand

Commit Message

Viacheslav Dubeyko Feb. 6, 2025, 7:11 p.m. UTC
From: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>

Process/Thread ID (pid) is crucial and essential info
during the debug and bug fix. It is really hard
to analyze the debug output without these details.
This patch addes PID info into the debug output.

Signed-off-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
---
 include/linux/ceph/ceph_debug.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Alex Markuze Feb. 6, 2025, 8:49 p.m. UTC | #1
Reviewed-by: Alex Markuze <amarkuze@redhat.com>

On Thu, Feb 6, 2025 at 9:11 PM Viacheslav Dubeyko <slava@dubeyko.com> wrote:
>
> From: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
>
> Process/Thread ID (pid) is crucial and essential info
> during the debug and bug fix. It is really hard
> to analyze the debug output without these details.
> This patch addes PID info into the debug output.
>
> Signed-off-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
> ---
>  include/linux/ceph/ceph_debug.h | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/ceph/ceph_debug.h b/include/linux/ceph/ceph_debug.h
> index 5f904591fa5f..6292db198f61 100644
> --- a/include/linux/ceph/ceph_debug.h
> +++ b/include/linux/ceph/ceph_debug.h
> @@ -16,13 +16,15 @@
>
>  # if defined(DEBUG) || defined(CONFIG_DYNAMIC_DEBUG)
>  #  define dout(fmt, ...)                                               \
> -       pr_debug("%.*s %12.12s:%-4d : " fmt,                            \
> +       pr_debug("pid %d %.*s %12.12s:%-4d : " fmt,                     \
> +                current->pid,                                          \
>                  8 - (int)sizeof(KBUILD_MODNAME), "    ",               \
>                  kbasename(__FILE__), __LINE__, ##__VA_ARGS__)
>  #  define doutc(client, fmt, ...)                                      \
> -       pr_debug("%.*s %12.12s:%-4d : [%pU %llu] " fmt,                 \
> +       pr_debug("pid %d %.*s %12.12s:%-4d %s() : [%pU %llu] " fmt,     \
> +                current->pid,                                          \
>                  8 - (int)sizeof(KBUILD_MODNAME), "    ",               \
> -                kbasename(__FILE__), __LINE__,                         \
> +                kbasename(__FILE__), __LINE__, __func__,               \
>                  &client->fsid, client->monc.auth->global_id,           \
>                  ##__VA_ARGS__)
>  # else
> --
> 2.48.0
>
diff mbox series

Patch

diff --git a/include/linux/ceph/ceph_debug.h b/include/linux/ceph/ceph_debug.h
index 5f904591fa5f..6292db198f61 100644
--- a/include/linux/ceph/ceph_debug.h
+++ b/include/linux/ceph/ceph_debug.h
@@ -16,13 +16,15 @@ 
 
 # if defined(DEBUG) || defined(CONFIG_DYNAMIC_DEBUG)
 #  define dout(fmt, ...)						\
-	pr_debug("%.*s %12.12s:%-4d : " fmt,				\
+	pr_debug("pid %d %.*s %12.12s:%-4d : " fmt,			\
+		 current->pid,						\
 		 8 - (int)sizeof(KBUILD_MODNAME), "    ",		\
 		 kbasename(__FILE__), __LINE__, ##__VA_ARGS__)
 #  define doutc(client, fmt, ...)					\
-	pr_debug("%.*s %12.12s:%-4d : [%pU %llu] " fmt,			\
+	pr_debug("pid %d %.*s %12.12s:%-4d %s() : [%pU %llu] " fmt,	\
+		 current->pid,						\
 		 8 - (int)sizeof(KBUILD_MODNAME), "    ",		\
-		 kbasename(__FILE__), __LINE__,				\
+		 kbasename(__FILE__), __LINE__, __func__,		\
 		 &client->fsid, client->monc.auth->global_id,		\
 		 ##__VA_ARGS__)
 # else