diff mbox

[4/5] rbd: kill rbd_dev->q

Message ID 5049F91F.3090306@inktank.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alex Elder Sept. 7, 2012, 1:39 p.m. UTC
A copy of rbd_dev->disk->queue is held in rbd_dev->q, but it's
never actually used.  So get just get rid of the field.

Signed-off-by: Alex Elder <elder@inktank.com>
---
 drivers/block/rbd.c |    2 --
 1 file changed, 2 deletions(-)

Comments

Josh Durgin Sept. 7, 2012, 6:16 p.m. UTC | #1
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>

On 09/07/2012 06:39 AM, Alex Elder wrote:
> A copy of rbd_dev->disk->queue is held in rbd_dev->q, but it's
> never actually used.  So get just get rid of the field.
>
> Signed-off-by: Alex Elder <elder@inktank.com>
> ---
>   drivers/block/rbd.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 7726368..774a36b 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -155,7 +155,6 @@ struct rbd_device {
>
>   	int			major;		/* blkdev assigned major */
>   	struct gendisk		*disk;		/* blkdev's gendisk and rq */
> -	struct request_queue	*q;
>
>   	struct rbd_options	rbd_opts;
>   	struct rbd_client	*rbd_client;
> @@ -1923,7 +1922,6 @@ static int rbd_init_disk(struct rbd_device *rbd_dev)
>   	q->queuedata = rbd_dev;
>
>   	rbd_dev->disk = disk;
> -	rbd_dev->q = q;
>
>   	/* finally, announce the disk to the world */
>   	set_capacity(disk, total_size / SECTOR_SIZE);
>

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 7726368..774a36b 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -155,7 +155,6 @@  struct rbd_device {

 	int			major;		/* blkdev assigned major */
 	struct gendisk		*disk;		/* blkdev's gendisk and rq */
-	struct request_queue	*q;

 	struct rbd_options	rbd_opts;
 	struct rbd_client	*rbd_client;
@@ -1923,7 +1922,6 @@  static int rbd_init_disk(struct rbd_device *rbd_dev)
 	q->queuedata = rbd_dev;

 	rbd_dev->disk = disk;
-	rbd_dev->q = q;

 	/* finally, announce the disk to the world */
 	set_capacity(disk, total_size / SECTOR_SIZE);