From patchwork Fri Feb 8 16:18:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 2116851 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 730C93FCA4 for ; Fri, 8 Feb 2013 16:19:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759956Ab3BHQTI (ORCPT ); Fri, 8 Feb 2013 11:19:08 -0500 Received: from mail-ia0-f180.google.com ([209.85.210.180]:55974 "EHLO mail-ia0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758646Ab3BHQTH (ORCPT ); Fri, 8 Feb 2013 11:19:07 -0500 Received: by mail-ia0-f180.google.com with SMTP id f27so4313743iae.25 for ; Fri, 08 Feb 2013 08:19:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding:x-gm-message-state; bh=1IVt/sLhXzw3jl0754muwas0xvShIxjCvnaH24SNGao=; b=FnCNJFrH/bq4syx/OJ5U012josPstdYMP2OhaQWHmp8fEI6ZxU9YHbwu2aJWJzqRp2 m9XjgCJzP3m4tKdDL/iPGpM8pFe9oJW7Hex5WdAun5B+bXDBAF/zN72HcssKmMrz+QJC XsEwbc1ABekhIsh0z/nYya8J3HvEuhkrb5ihWEsYo60QG3jnitkwO5xekF4DCKnCY3Ua Lf8sjB0hDOIz9uhY6cpR29Gkuf4QOuWKdBkfifEzFsX1q5LRvc0uNNu3U1GWALOwOL+0 MTSNnEVZwvpyv3LHvZTLL29Stqq+KpbCBV/rKIqZ3WQfQQ30wrD7oJ/xkEbl0B0LQgf6 Le+Q== X-Received: by 10.50.203.3 with SMTP id km3mr3424521igc.64.1360340344629; Fri, 08 Feb 2013 08:19:04 -0800 (PST) Received: from [172.22.22.4] (c-71-195-31-37.hsd1.mn.comcast.net. [71.195.31.37]) by mx.google.com with ESMTPS id j11sm15716312igc.5.2013.02.08.08.18.59 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 08 Feb 2013 08:19:00 -0800 (PST) Message-ID: <51152572.1060602@inktank.com> Date: Fri, 08 Feb 2013 10:18:58 -0600 From: Alex Elder User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: "ceph-devel@vger.kernel.org" Subject: [PATCH] rbd: add parentheses to object request iterator macros X-Gm-Message-State: ALoCoQlK8KyEh8zNRRQx18hYNjbGLu5KN43+wIYscroWOVloD/eFRKFlJg9sxz4DRS1QxhVPvxP0 Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org The for_each_obj_request*() macros should parenthesize their uses of the ireq parameter. Signed-off-by: Alex Elder Reviewed-by: Josh Durgin --- drivers/block/rbd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 982963e..6e9e2c2 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -226,11 +226,11 @@ struct rbd_img_request { }; #define for_each_obj_request(ireq, oreq) \ - list_for_each_entry(oreq, &ireq->obj_requests, links) + list_for_each_entry(oreq, &(ireq)->obj_requests, links) #define for_each_obj_request_from(ireq, oreq) \ - list_for_each_entry_from(oreq, &ireq->obj_requests, links) + list_for_each_entry_from(oreq, &(ireq)->obj_requests, links) #define for_each_obj_request_safe(ireq, oreq, n) \ - list_for_each_entry_safe_reverse(oreq, n, &ireq->obj_requests, links) + list_for_each_entry_safe_reverse(oreq, n, &(ireq)->obj_requests, links) struct rbd_snap { struct device dev;