diff mbox

[3/3] libceph: no need for alignment for mds message

Message ID 5134E40C.1090303@inktank.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alex Elder March 4, 2013, 6:12 p.m. UTC
Currently, incoming mds messages never use page data, which means
there is no need to set the page_alignment field in the message.

Signed-off-by: Alex Elder <elder@inktank.com>
---
 fs/ceph/mds_client.c |    1 -
 1 file changed, 1 deletion(-)

 }

Comments

Gregory Farnum March 4, 2013, 7:09 p.m. UTC | #1
Looks good.
Reviewed-by: Greg Farnum <greg@inktank.com>

On Mon, Mar 4, 2013 at 10:12 AM, Alex Elder <elder@inktank.com> wrote:
> Currently, incoming mds messages never use page data, which means
> there is no need to set the page_alignment field in the message.
>
> Signed-off-by: Alex Elder <elder@inktank.com>
> ---
>  fs/ceph/mds_client.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index a4b986a..afb9dc9 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -3486,7 +3486,6 @@ static struct ceph_msg *mds_alloc_msg(struct
> ceph_connection *con,
>                        type, front_len);
>                 return NULL;
>         }
> -       msg->page_alignment = (unsigned int) le16_to_cpu(hdr->data_off);
>
>         return msg;
>  }
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index a4b986a..afb9dc9 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -3486,7 +3486,6 @@  static struct ceph_msg *mds_alloc_msg(struct
ceph_connection *con,
 		       type, front_len);
 		return NULL;
 	}
-	msg->page_alignment = (unsigned int) le16_to_cpu(hdr->data_off);

 	return msg;