From patchwork Wed May 29 20:51:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 2632701 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id BD3FA3FC23 for ; Wed, 29 May 2013 20:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966926Ab3E2Uu6 (ORCPT ); Wed, 29 May 2013 16:50:58 -0400 Received: from mail-ve0-f171.google.com ([209.85.128.171]:45984 "EHLO mail-ve0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966493Ab3E2Uu5 (ORCPT ); Wed, 29 May 2013 16:50:57 -0400 Received: by mail-ve0-f171.google.com with SMTP id b10so1588123vea.30 for ; Wed, 29 May 2013 13:50:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding:x-gm-message-state; bh=wKh8b9Q/DskCKJH3K1QO2JDptl/6G/fn7iK07Jph6l8=; b=N4l/XgNXq76D29ruRvBORSR3gBfiFupQ/Ri/S6uvgUUjnTPagp/EttMOWyXg8ecpIc zS2cKW7WtombUhEZWl8DnkgCD3M3nUlpzvDRr8daa+dSs3YLiDXDFPlJWEqwDI/sjc5n B+djd6wXIOXj/56YYmm3p7dmUI0gG8zpOyCiSabbxcxoAGCN7fuGLRs4oF/GmbIHjcLT 5w/SJN8SAvwbY+bJWpH5Umfg07ha6YNvxPSXxiWbmc7OsRhWSc7TnO77cDcrtC8zKcj4 LYe1QppxjmEkdt20bCvowJJJOKp85tu1zyIWuYRX+JXNQkE/emnos2TNdnjgXq2cHBJv mZKA== X-Received: by 10.220.79.18 with SMTP id n18mr2823110vck.15.1369860656804; Wed, 29 May 2013 13:50:56 -0700 (PDT) Received: from [172.22.22.4] (c-71-195-31-37.hsd1.mn.comcast.net. [71.195.31.37]) by mx.google.com with ESMTPSA id bk7sm29361870ved.0.2013.05.29.13.50.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 29 May 2013 13:50:56 -0700 (PDT) Message-ID: <51A66A3F.4040707@inktank.com> Date: Wed, 29 May 2013 15:51:11 -0500 From: Alex Elder User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: ceph-devel@vger.kernel.org Subject: [PATCH] libceph: print more info for short message header X-Gm-Message-State: ALoCoQmcW6CucqAgKLvDL6AqwCto2Xr9yoxR2RTSzYmpDFdy+ca5YNyWCjb7ESGXbcc+zKnJDCRp Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org If an osd client response message arrives that has a front section that's too big for the buffer set aside to receive it, a warning gets reported and a new buffer is allocated. The warning says nothing about which connection had the problem. Add the peer type and number to what gets reported, to be a bit more informative. Signed-off-by: Alex Elder Reviewed-by: Josh Durgin --- net/ceph/osd_client.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) goto out; diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c index e0abb83..61147fe 100644 --- a/net/ceph/osd_client.c +++ b/net/ceph/osd_client.c @@ -2454,8 +2454,10 @@ static struct ceph_msg *get_reply(struct ceph_connection *con, ceph_msg_revoke_incoming(req->r_reply); if (front > req->r_reply->front.iov_len) { - pr_warning("get_reply front %d > preallocated %d\n", - front, (int)req->r_reply->front.iov_len); + pr_warning("get_reply front %d > preallocated %d (%u#%llu)\n", + front, (int)req->r_reply->front.iov_len, + (unsigned int)con->peer_name.type, + le64_to_cpu(con->peer_name.num)); m = ceph_msg_new(CEPH_MSG_OSD_OPREPLY, front, GFP_NOFS, false); if (!m)