From patchwork Tue Dec 3 02:42:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Kirkwood X-Patchwork-Id: 3272981 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A6066C0D4A for ; Tue, 3 Dec 2013 02:42:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C2D6F20304 for ; Tue, 3 Dec 2013 02:42:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6507120251 for ; Tue, 3 Dec 2013 02:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753131Ab3LCCmy (ORCPT ); Mon, 2 Dec 2013 21:42:54 -0500 Received: from bertrand.catalyst.net.nz ([202.78.240.40]:51944 "EHLO mail.catalyst.net.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709Ab3LCCmy (ORCPT ); Mon, 2 Dec 2013 21:42:54 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.catalyst.net.nz (Postfix) with ESMTP id 4EFD96780A for ; Tue, 3 Dec 2013 15:42:50 +1300 (NZDT) X-Virus-Scanned: Debian amavisd-new at catalyst.net.nz Received: from mail.catalyst.net.nz ([127.0.0.1]) by localhost (bertrand.catalyst.net.nz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tl7AbhXCUHNV for ; Tue, 3 Dec 2013 15:42:48 +1300 (NZDT) Received: from [IPv6:2404:130:0:1000:222:4dff:fe88:a586] (unknown [IPv6:2404:130:0:1000:222:4dff:fe88:a586]) (Authenticated sender: mark.kirkwood) by mail.catalyst.net.nz (Postfix) with ESMTPSA id 36AF867816 for ; Tue, 3 Dec 2013 15:42:48 +1300 (NZDT) Message-ID: <529D4528.3050901@catalyst.net.nz> Date: Tue, 03 Dec 2013 15:42:48 +1300 From: Mark Kirkwood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: "ceph-devel@vger.kernel.org" Subject: Osd magic detection failure in master Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I just updated master (a5eda4fcc34461dbc0fcc47448f8456097de15eb), and am seeing OSDs failing to start: 2013-12-03 15:37:01.291200 7f488e1157c0 -1 OSD magic != my ceph osd volume v026 failed: 'ulimit -n 32768; /usr/bin/ceph-osd -i 0 --pid-file /var/run/ceph/osd.0.pid -c /etc/ceph/ceph.conf ' Now it appears that the magic is not being read. It is however there and seemingly ok: $ cat /var/lib/ceph/osd/ceph-0/magic ceph osd volume v026 Looking at src/osd/OSD.cc I wonder if something like this is needed (as it seems that magic is being assigned to an empty val otherwise): magic = val; This makes the osd's start ok, but the mon does not detect them (possibly another issue or my patch is wrong). I'll keep looking :-) Cheers Mark --- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/src/osd/OSD.cc +++ b/src/osd/OSD.cc @@ -731,7 +731,7 @@ int OSD::peek_meta(ObjectStore *store, std::string& magic, { string val; - int r = store->read_meta("magic", &magic); + int r = store->read_meta("magic", &val); if (r < 0) return r;