From patchwork Wed Aug 21 20:01:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Noah Watkins X-Patchwork-Id: 2847893 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9D3799F2F6 for ; Wed, 21 Aug 2013 20:01:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 08C5820456 for ; Wed, 21 Aug 2013 20:01:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28A682047C for ; Wed, 21 Aug 2013 20:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657Ab3HUUBR (ORCPT ); Wed, 21 Aug 2013 16:01:17 -0400 Received: from mail-ve0-f175.google.com ([209.85.128.175]:34653 "EHLO mail-ve0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752589Ab3HUUBR (ORCPT ); Wed, 21 Aug 2013 16:01:17 -0400 Received: by mail-ve0-f175.google.com with SMTP id oy10so777416veb.34 for ; Wed, 21 Aug 2013 13:01:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=1A4IcJONY21R8+zeq11taOKMgobJUR9dafpPDeR/B9U=; b=kPr/J6b8oXxzQTJQ821xqv10edBLeAo0zVTexnRUbl4RXo5uzXiWSnCwXdYWDoLDbZ Z231MyEroGhG+6o2GKe04qcCM7/u+C+n//aV17gEONiLN3mO5DLLTyY3rMJt73jnMswT bDY8JeGEgOd6Ch9vKKI2Phec3Fs+gVMKMX8C3GHBEVkOo/S2vpNC3Othj2Qxk7R59xjo hC9edvpA1cVcoYqySHSUPIEvuNCJTddd1V3H9EQh7z2C+of6kIS9XfwljlFIo7oUXFYe FeXvQGEtSfpVH8UKDmeNYzf9dtIsqgezQBPQsaqD+mXHex/n+HA5JW+WLiN/hzIaelyv t9cQ== X-Gm-Message-State: ALoCoQnAFlTr9jH7EBSI9JeHnx8bzd2NApeH30f6aZfvxiBzWGo2vzfaAhP2vchHxSfGPwB/oPwf MIME-Version: 1.0 X-Received: by 10.52.103.73 with SMTP id fu9mr2802280vdb.29.1377115276554; Wed, 21 Aug 2013 13:01:16 -0700 (PDT) Received: by 10.58.186.166 with HTTP; Wed, 21 Aug 2013 13:01:16 -0700 (PDT) In-Reply-To: References: Date: Wed, 21 Aug 2013 13:01:16 -0700 Message-ID: Subject: Re: subdir-objects From: Noah Watkins To: Roald van Loon Cc: "ceph-devel@vger.kernel.org" Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Aug 21, 2013 at 12:45 PM, Roald van Loon wrote: > > from auto-registering the plugins in the RGW core. The only fix for > this is making the RGW core aware of the subdirs/plugins, but I think > that's nasty design. I'd like to have it in my make conf. This patch will turn on the option (which should also fix your problem if I understand correctly?), and should probably be committed anyway as newer versions of autotools will complain loudly about our current Makefile structure. > So, the question is; is there a reason why we don't use subdir objects? I believe it is just historical, and unfortunately has just been repeated over and over. Ideally I think that there should be a restructuring to place a Makefile.am in every subdirectory. This would address your issue and make it significantly easier to deal with situations where we want to build a subset of Ceph, such as just FUSE and librados, for example. --- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/src/Makefile.am b/src/Makefile.am index 93f3331..fb7c9dd 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,4 +1,4 @@ -AUTOMAKE_OPTIONS = gnu +AUTOMAKE_OPTIONS = gnu subdir-objects SUBDIRS = ocf java DIST_SUBDIRS = gtest ocf libs3 java