From patchwork Sat Feb 22 04:25:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: huang jun X-Patchwork-Id: 3700901 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 429009F2EC for ; Sat, 22 Feb 2014 04:25:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 24C14201B9 for ; Sat, 22 Feb 2014 04:25:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B92E62018B for ; Sat, 22 Feb 2014 04:25:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752477AbaBVEZW (ORCPT ); Fri, 21 Feb 2014 23:25:22 -0500 Received: from mail-la0-f44.google.com ([209.85.215.44]:61807 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752324AbaBVEZV (ORCPT ); Fri, 21 Feb 2014 23:25:21 -0500 Received: by mail-la0-f44.google.com with SMTP id hr13so157240lab.31 for ; Fri, 21 Feb 2014 20:25:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=lfTvi0PbOTQmAn3bM+os9hBPKwLy2ZckbSMOxpZMeH0=; b=cdbeHwUSuXbWwb2dZaHAxykwjfqu6os5cOiompdobv30X9z8ITJbrbBiQL/Ux6WmLo PdoozdUvjQBj7eTgLWOiQkxyPqRxR9CgbGq2HXx6TDQdkrFIXNtgvlmOmM5Wnocfjkav 7Q8erL1FD73SXIew0nuK6vkieJF2c+LKDGhtUKLlQmHqRyuiHklS5mfAP1juF0uZajoE oYFbfwCqWVbEQah6McOWzfWOWNRoomZKa1zrzLkBK1rnqGRUOgaGylMR8ltVGjo4WzEe lnQTu0RiMacaoxOK8rX2pQX2fvnbPF/VnYVFMtognEXw4uEwi0uHeovj6ftQXgnvsV0w IEjw== MIME-Version: 1.0 X-Received: by 10.152.234.3 with SMTP id ua3mr5912855lac.63.1393043119839; Fri, 21 Feb 2014 20:25:19 -0800 (PST) Received: by 10.114.75.241 with HTTP; Fri, 21 Feb 2014 20:25:19 -0800 (PST) In-Reply-To: References: Date: Sat, 22 Feb 2014 12:25:19 +0800 Message-ID: Subject: Re: Fixes for missing and replicated files in ceph.spec.in From: huang jun To: Ken Dreyer Cc: Sage Weil , ceph-devel Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP we can also use test_* instead of listing all test_xx files while building debian package 2014-02-22 7:04 GMT+08:00 Ken Dreyer : > On Fri, Feb 21, 2014 at 1:48 PM, Sage Weil wrote: >> On Fri, 21 Feb 2014, Ken Dreyer wrote: >>> On Fri, Feb 21, 2014 at 4:27 AM, huang jun wrote: >>> > @@ -690,6 +689,7 @@ fi >>> > %{_bindir}/ceph_test_rados_list_parallel >>> > %{_bindir}/ceph_test_rados_open_pools_parallel >>> > %{_bindir}/ceph_test_rados_watch_notify >>> > +%{_bindir}/ceph_test_rgw_manifest >>> > %{_bindir}/ceph_test_signal_handlers >>> > %{_bindir}/ceph_test_snap_mapper >>> >>> >>> It seems like we have to deal with this sort of thing over and over. >>> Anyone have objections to simply using a wildcard to capture all the >>> test files? Something like %{_bindir}/ceph_test_* ? >> >> Sounds good to me. This is only stuff that 'make install' is putting in >> place right? > > Yep, that's right, the wildcard will just match what 'make install' has done. > > Pull request is at https://github.com/ceph/ceph/pull/1287 . Huang, if > you have time, it would be great to get your review before we merge. > > - Ken diff --git a/debian/ceph-test.install b/debian/ceph-test.install index bdcb75f..ac79055 100644 --- a/debian/ceph-test.install +++ b/debian/ceph-test.install @@ -19,63 +19,7 @@ usr/bin/ceph_smalliobenchdumb usr/bin/ceph_smalliobenchfs usr/bin/ceph_smalliobenchrbd usr/bin/ceph_streamtest -usr/bin/ceph_test_cfuse_cache_invalidate -usr/bin/ceph_test_cls_hello -usr/bin/ceph_test_cls_lock -usr/bin/ceph_test_cls_log -usr/bin/ceph_test_cls_rbd -usr/bin/ceph_test_cls_refcount -usr/bin/ceph_test_cls_replica_log -usr/bin/ceph_test_cls_rgw -usr/bin/ceph_test_cls_rgw_log -usr/bin/ceph_test_cls_rgw_meta -usr/bin/ceph_test_cls_rgw_opstate -usr/bin/ceph_test_cls_statelog -usr/bin/ceph_test_cls_version -usr/bin/ceph_test_cors -usr/bin/ceph_test_crypto -usr/bin/ceph_test_filejournal -usr/bin/ceph_test_objectstore -usr/bin/ceph_test_filestore_idempotent -usr/bin/ceph_test_filestore_idempotent_sequence -usr/bin/ceph_test_objectstore_workloadgen -usr/bin/ceph_test_ioctls -usr/bin/ceph_test_keys -usr/bin/ceph_test_keyvaluedb_atomicity -usr/bin/ceph_test_keyvaluedb_iterators -usr/bin/ceph_test_libcephfs -usr/bin/ceph_test_librbd -usr/bin/ceph_test_librbd_fsx -usr/bin/ceph_test_mon_workloadgen -usr/bin/ceph_test_msgr -usr/bin/ceph_test_mutate -usr/bin/ceph_test_object_map -usr/bin/ceph_test_objectcacher_stress -usr/bin/ceph_test_rados -usr/bin/ceph_test_rados_api_aio -usr/bin/ceph_test_rados_api_cls -usr/bin/ceph_test_rados_api_c_read_operations -usr/bin/ceph_test_rados_api_c_write_operations -usr/bin/ceph_test_rados_api_cmd -usr/bin/ceph_test_rados_api_io -usr/bin/ceph_test_rados_api_list -usr/bin/ceph_test_rados_api_lock -usr/bin/ceph_test_rados_api_misc -usr/bin/ceph_test_rados_api_tier -usr/bin/ceph_test_rados_api_pool -usr/bin/ceph_test_rados_api_snapshots -usr/bin/ceph_test_rados_api_stat -usr/bin/ceph_test_rados_api_watch_notify -usr/bin/ceph_test_rados_delete_pools_parallel -usr/bin/ceph_test_rados_list_parallel -usr/bin/ceph_test_rados_open_pools_parallel -usr/bin/ceph_test_rados_watch_notify -usr/bin/ceph_test_rewrite_latency -usr/bin/ceph_test_signal_handlers -usr/bin/ceph_test_snap_mapper -usr/bin/ceph_test_stress_watch -usr/bin/ceph_test_timers -usr/bin/ceph_test_trans +usr/bin/ceph_test_* usr/bin/ceph_tpbench usr/bin/ceph_xattr_bench usr/bin/ceph-monstore-tool