From patchwork Mon Nov 11 11:44:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ketor D X-Patchwork-Id: 3167151 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 338659F3AE for ; Mon, 11 Nov 2013 11:45:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9CAE920377 for ; Mon, 11 Nov 2013 11:45:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E3D620360 for ; Mon, 11 Nov 2013 11:45:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753009Ab3KKLpU (ORCPT ); Mon, 11 Nov 2013 06:45:20 -0500 Received: from mail-lb0-f171.google.com ([209.85.217.171]:44904 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752967Ab3KKLpT (ORCPT ); Mon, 11 Nov 2013 06:45:19 -0500 Received: by mail-lb0-f171.google.com with SMTP id x18so3380915lbi.30 for ; Mon, 11 Nov 2013 03:45:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:cc:content-type; bh=DIEH4WFNR/e1A9L6zT2gU98AIXq6q9ThMkjDPyhO4q8=; b=hLN1q1XsTpl/Pdn0+yZaJ/hmiFxsWTLnaO+9E/71/X/zakUb5uPFuPf7zJB8JA3OiR mpu7SpeegzNVBNamUucenOrtJlUhj8cC3k/hLxn+vwV4xRzZWLAocTZXCuKa5q3SmrFv 5965C8fLyAqq10dLT0ybRsdQtrAOO6z25+muxaQRd312l5DlZ4Q8o6pddQqFdcfdBNla cRxqXn+ef+UGrj0Va8Ch+dauPcZxxgOP0FZgwZAC5VKBGKOLCU/ZOP0I2EhMUoPWORAo HH2cqkst7CIW3Znbo5mAWIuYAQUcQJnPSAlSPEw65L6W0sn5MsWRfAyxu1H64x9dooaN YWWw== X-Received: by 10.152.216.167 with SMTP id or7mr22557584lac.10.1384170317593; Mon, 11 Nov 2013 03:45:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.114.200.3 with HTTP; Mon, 11 Nov 2013 03:44:47 -0800 (PST) From: Ketor D Date: Mon, 11 Nov 2013 19:44:47 +0800 Message-ID: Subject: [PATCH]ceph:init-ceph can't start osds after using mkcephfs created cluster To: Sage Weil Cc: ceph-devel Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Sage: We always use mkcephfs to create out ceph cluster. Before 0.72, all is ok. But in 0.72, we found the osds can't start up useing "service ceph -a start". After viewing the init-ceph.in script , I found that a return value errro caused osds can't startup.And if we modifiy a little code like 0.67.4 do, the osds can startup. Regards! Here is the patch: Signed-off-by: Ketor D --- the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git "a/src/init-ceph.in" "b/src/init-ceph.in" index 7399abb..cf2eaa6 100644 --- "a/src/init-ceph.in" +++ "b/src/init-ceph.in" @@ -331,7 +331,8 @@ for name in $what; do -- \ $id \ ${osd_weight:-${defaultweight:-1}} \ - $osd_location" + $osd_location \ + || :" fi fi -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in