| Message ID | ormwvhnyj2.fsf@livre.home (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Alex - This patch has been merged to master. I made the same change to the new rgw logrotate.conf. Cheers, Gary On Feb 6, 2013, at 9:27 AM, Alexandre Oliva wrote: > I was getting email with logrotate error output from “which invoke-rc.d” > on systems without an invoke-rc.d. This patch silences it. > > Silence stderr from which when running logrotate > > From: Alexandre Oliva <oliva@gnu.org> > > Signed-off-by: Alexandre Oliva <oliva@gnu.org> > --- > src/logrotate.conf | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/logrotate.conf b/src/logrotate.conf > index 9af3104..c443eed 100644 > --- a/src/logrotate.conf > +++ b/src/logrotate.conf > @@ -4,13 +4,16 @@ > compress > sharedscripts > postrotate > - if which invoke-rc.d > /dev/null && [ -x `which invoke-rc.d` ]; then > + if which invoke-rc.d > /dev/null 2>&1 && > + [ -x `which invoke-rc.d` ]; then > invoke-rc.d ceph reload >/dev/null > - elif which service > /dev/null && [ -x `which service` ]; then > + elif which service > /dev/null 2>&1 && > + [ -x `which service` ]; then > service ceph reload >/dev/null > fi > # Possibly reload twice, but depending on ceph.conf the reload above may be a no-op > - if which initctl > /dev/null && [ -x `which initctl` ]; then > + if which initctl > /dev/null 2>&1 && > + [ -x `which initctl` ]; then > # upstart reload isn't very helpful here: > # https://bugs.launchpad.net/upstart/+bug/1012938 > for type in mon osd mds; do > > > -- > Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ > You must be the change you wish to see in the world. -- Gandhi > Be Free! -- http://FSFLA.org/ FSF Latin America board member > Free Software Evangelist Red Hat Brazil Compiler Engineer -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Silence stderr from which when running logrotate From: Alexandre Oliva <oliva@gnu.org> Signed-off-by: Alexandre Oliva <oliva@gnu.org> --- src/logrotate.conf | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/logrotate.conf b/src/logrotate.conf index 9af3104..c443eed 100644 --- a/src/logrotate.conf +++ b/src/logrotate.conf @@ -4,13 +4,16 @@ compress sharedscripts postrotate - if which invoke-rc.d > /dev/null && [ -x `which invoke-rc.d` ]; then + if which invoke-rc.d > /dev/null 2>&1 && + [ -x `which invoke-rc.d` ]; then invoke-rc.d ceph reload >/dev/null - elif which service > /dev/null && [ -x `which service` ]; then + elif which service > /dev/null 2>&1 && + [ -x `which service` ]; then service ceph reload >/dev/null fi # Possibly reload twice, but depending on ceph.conf the reload above may be a no-op - if which initctl > /dev/null && [ -x `which initctl` ]; then + if which initctl > /dev/null 2>&1 && + [ -x `which initctl` ]; then # upstart reload isn't very helpful here: # https://bugs.launchpad.net/upstart/+bug/1012938 for type in mon osd mds; do