mbox series

[v3,0/2] Add support for IO memory mapped EC

Message ID 20250107174514.2748108-1-gwendal@chromium.org (mailing list archive)
Headers show
Series Add support for IO memory mapped EC | expand

Message

Gwendal Grignou Jan. 7, 2025, 5:45 p.m. UTC
Some EC - Realtek - have their register IO mapped by the BIOS -
coreboot. They are not using the well know io register.

The memory mapping information is retrieved through the ACPI CRS
resource, and is used to access the registers.

To ease the support of these ECs, the global structure and accessor
funcions are now aware of the EC device private structure.

Gwendal Grignou (2):
  platform/chrome: cros_ec_lpc: Merge lpc_driver_ops into ec
    private structure
  platform/chrome: cros_ec_lpc: Add Support for direct EC
    register memory access

---
Changes in v3:
  Fix handling of devm_ioremap error
  Reword commit message to be more descriptive.
Changes in v2:
  Removed obvious comments, unnecessary case statement and fix error
  code return.

 drivers/platform/chrome/cros_ec_lpc.c | 203 ++++++++++++++++++--------
 1 file changed, 139 insertions(+), 64 deletions(-)

Comments

Tzung-Bi Shih Jan. 8, 2025, 2:26 a.m. UTC | #1
On Tue, Jan 07, 2025 at 09:45:12AM -0800, Gwendal Grignou wrote:
> Some EC - Realtek - have their register IO mapped by the BIOS -
> coreboot. They are not using the well know io register.
> 
> The memory mapping information is retrieved through the ACPI CRS
> resource, and is used to access the registers.
> 
> To ease the support of these ECs, the global structure and accessor
> funcions are now aware of the EC device private structure.
>
> [...]

Have removed the redundant title prefix "FROMLIST" and fixed a minor typo.

Applied to

    https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next

[1/2] platform/chrome: cros_ec_lpc: Merge lpc_driver_ops into ec private structure
      commit: 58517215304b6113beaa3a319ed19cdd9f8fbcc1
[2/2] platform/chrome: cros_ec_lpc: Support direct EC register memory access
      commit: be4fccb5e1fb5c732f2868b9a278e71d9be0283c

Thanks!