From patchwork Mon Mar 10 12:40:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14009925 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92BD122B5AA for ; Mon, 10 Mar 2025 12:40:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741610441; cv=none; b=XvaHrRTmWgIDSz7HLi2/YeltDIzhw+PVvMtuTdKxjugMx2SPiQbu+Bub9LhsoarOPJswoaP4xwZtt0lWpcBs3oQY6jFf5olgByIKtxJnPd7VuhQ5S26ofalwLKeONLCrmRzfS+//DJHPFiJ6g5vvf3AmCEnjfpyLDX+km7roMiw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741610441; c=relaxed/simple; bh=an+fP7Mru70xaNnEI2kekcGYASlHb28T6SJ68s0UULo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Szz5z6Wu0eUqhWEO2zIXYDvTGe7MqNvgj/BZElQBoywtMTyP9Tu8Om88w5CB5begqv0giPBUtrtOsEqQkXsGPPMQzuQeywRkn1yX7HLUMApaF+/xMOZqZlRJIPcN3UgTnG8qzbyP6u0n8MadOl652ivGLEsnMY28tyboqWKItRQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=HvNdXDEz; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="HvNdXDEz" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3913d45a148so1301942f8f.3 for ; Mon, 10 Mar 2025 05:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1741610438; x=1742215238; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=H67PL+TODiTrJrMnnAUO7rPrwzkz/ZoBAK5iB5c1v5k=; b=HvNdXDEzvXFkti20nTwIolml3RZzChLg8/6s6qoj/Te1KcslDZEu6BrEniWbFZLnRX TF+GeHNH6nzvZM5NDcLA0E3fJlBuxdx8VZdJEuuq/Hs5jLKtH+KCHk7UHYd39nEfZm0t TJ+k1mLto8BF6qhy8N9/ORBD9b9gH6Q8avIekI7Xr7g++W8ucCnxXIfMsLxWLOOkzdNL 3ldZ6SAqzrBnbuFDYKgjDaWFiJb3X0Jye35i09rv8Ca306PaU0uTxd5e6hQXxkp3xASN AQWpTAn9ZAyFxq9qTC1zcA551DBZnetq7souNu8k6Uznjixxs6/xuEh2IrZUY3i+guO8 up8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741610438; x=1742215238; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H67PL+TODiTrJrMnnAUO7rPrwzkz/ZoBAK5iB5c1v5k=; b=dzxUP0YQpqlX1IkNIIeJnGcQ8Ih4bLwsx4ZPAjPRW40f7RL4NcQFdqAKK3iWk3pkCc gys/UGLR1ykFzAIffZuKK6CX/ittdgDuiDpdNN4aspKA5nZv9KGl/k0rW5RqPwb5Fvx8 F+YduXkdUQ7yv4t68d8v94ZJR0Lhn3cOCO84ADU0i5qEPsOkB7Wdx/jkY4iBbju0IQ+B hRWxgzI5xcxcd8CQuq+UzXTrGjwfPELaw0eB6i6lfqBlj1LE5ObE4LPe1tifMddo3S5e BZ/mT3OdgVq+wC0XiadaqCG2NkClyF/Rt78j0v6VhBntkO64zuihK3sv5h8fKdF24jLf 9MXw== X-Forwarded-Encrypted: i=1; AJvYcCVRiseAfNqmJ0MA9SP4qvdywChj+NZdFR1/GTSgBpqmMaG84AKgQijW6MWGBB6eoND9qA6OJTThk5FePpI9lxU=@lists.linux.dev X-Gm-Message-State: AOJu0Yx9791nBOxVRzBVnzQPF9K1zZYJHv8tdaEm5nWAv5/hTHm8FF5N fx9dCVpfmeQyRJw2N0+dMmZ1BfXb4ZICspCHpLZn7xEGDjnoLOlphZxCrGVl8zQ= X-Gm-Gg: ASbGncvOYWRzjT1OUR64UEa4BSfFbhnZNv8ruZqjsdLF08/OlGRBKbzy1dCyKWBG3vr 9SjrTPWeWm+RP/Z5E8gXgZnw7GlEUMkecwt3Sq3yZsIvlGPr4/7saEka7n2Mv1qUuVLxYn61nI8 ZKsgPyfj/n+yaWhSFLwqHsiILOMgoq3ygmtOBG/h/jj6jenfZYco5bKbXc9yQ0mdBsnoh9bH4VB UDcjmRXUtq5QJrHBIHSQ6IhrOQmE8l/V9uEISHRou8okjloodlY9DAYOwQlj1I9+Som8xMYYA/F nBhT69qYLtNpU7Sr7eBSfgp3vYX5caL+LaZUXA== X-Google-Smtp-Source: AGHT+IHjIzliJ6rTfZiH4n3UkxkJcqMKZdYBYvY8eKvqKod7sCTO2s6497FITea5bFS321oo9wuZSg== X-Received: by 2002:a5d:64e4:0:b0:391:4889:5045 with SMTP id ffacd0b85a97d-391488951femr2560499f8f.36.1741610437863; Mon, 10 Mar 2025 05:40:37 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2711:39c0:fb51:b639]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfdfdc5sm14535865f8f.25.2025.03.10.05.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 05:40:37 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 10 Mar 2025 13:40:25 +0100 Subject: [PATCH 11/15] gpio: cros-ec: use new line value setter callbacks Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250310-gpiochip-set-conversion-v1-11-03798bb833eb@linaro.org> References: <20250310-gpiochip-set-conversion-v1-0-03798bb833eb@linaro.org> In-Reply-To: <20250310-gpiochip-set-conversion-v1-0-03798bb833eb@linaro.org> To: Ray Jui , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Scott Branden , Matti Vaittinen , Marek Vasut , Michael Buesch , Thomas Richard , Eugeniy Paltsev , Benson Leung , Guenter Roeck , Andy Shevchenko , Support Opensource Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, chrome-platform@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1839; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=mf+lhnl77k+//huQWe9emQFE2kvk1m73N1tBKnwoBnM=; b=kA0DAAoBEacuoBRx13IByyZiAGfO3behiP1ij9aD+aqKdAjP5QW4rawFipO8AKhppE44TNXtk okCMwQAAQoAHRYhBBad62wLw8RgE9LHnxGnLqAUcddyBQJnzt23AAoJEBGnLqAUcddyefEP+wXt sBVW2A1B7Mj2T4DFX6dl0Eey5mAcH8eeTbNYT/BFiOBPA7rn380y39f4nROcug0PbNb1Tsszqbm CzR1zvo4pNa1rtNPEDur8VWqvb15eC0e0tX830mj8j3cF0nLZkSjrHnfyeTVgE86gexHDTpndq8 blZv/Q5Y9z/vnMEYxK2tAUD2qR34yFwgo6a03/euLYr57quf8CQGpmgRMtVrj0t4+LqdDBIqQZL 9hoRXz1ajW5/kOtbtrpxSBRuigKDy2c7UU3fKe4+gIGr3oueFFSWcRJFPnhx5TNGuWnX976oRu6 PrcdKh2LVdOwuMa3FJf06h+364irmp3peYYP7vHZvppY+N4usY31p0eQEfPwPic3aBTnEZwNQfc lbimXOOagyNMBhEhTZ/lJznxlmZSWAJ6mm+Bm6FYY1FoqCXRqbEmpxDoJNGKVSEmhi+ZgbOJ55i oje3S2uWnGtavaul/BqekSB18sOV8y6jhF5lJn2qnLcgXqjsdmXnxNHhBWe3O2Bqstz6M3iUr+D UqWAAefc0ZUVWhUsWDyHF3a7UjNksNOIoVsmUTvRglhox2voc4BKqJ1ZO0afbsGdZ5zu+82XTe1 LSVUnTXIhh5BMOkU0eMA8Aa/z6WXjuvTDkAxPmsPE079y23XF44sKmMN0LBiZeCbB3PPOHqroIE WAAk6 X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Tzung-Bi Shih --- drivers/gpio/gpio-cros-ec.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-cros-ec.c b/drivers/gpio/gpio-cros-ec.c index 0c09bb54dc0c..53cd5ff6247b 100644 --- a/drivers/gpio/gpio-cros-ec.c +++ b/drivers/gpio/gpio-cros-ec.c @@ -24,24 +24,21 @@ static const char cros_ec_gpio_prefix[] = "EC:"; /* Setting gpios is only supported when the system is unlocked */ -static void cros_ec_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) +static int cros_ec_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) { const char *name = gc->names[gpio] + strlen(cros_ec_gpio_prefix); struct cros_ec_device *cros_ec = gpiochip_get_data(gc); struct ec_params_gpio_set params = { .val = val, }; - int ret; ssize_t copied; copied = strscpy(params.name, name, sizeof(params.name)); if (copied < 0) - return; + return copied; - ret = cros_ec_cmd(cros_ec, 0, EC_CMD_GPIO_SET, ¶ms, - sizeof(params), NULL, 0); - if (ret < 0) - dev_err(gc->parent, "error setting gpio%d (%s) on EC: %d\n", gpio, name, ret); + return cros_ec_cmd(cros_ec, 0, EC_CMD_GPIO_SET, ¶ms, + sizeof(params), NULL, 0); } static int cros_ec_gpio_get(struct gpio_chip *gc, unsigned int gpio) @@ -191,7 +188,7 @@ static int cros_ec_gpio_probe(struct platform_device *pdev) gc->can_sleep = true; gc->label = dev_name(dev); gc->base = -1; - gc->set = cros_ec_gpio_set; + gc->set_rv = cros_ec_gpio_set; gc->get = cros_ec_gpio_get; gc->get_direction = cros_ec_gpio_get_direction;