From patchwork Tue Feb 28 22:38:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13155312 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 415BCC64EC7 for ; Tue, 28 Feb 2023 22:39:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbjB1Wjf (ORCPT ); Tue, 28 Feb 2023 17:39:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbjB1Wj3 (ORCPT ); Tue, 28 Feb 2023 17:39:29 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53D8D15571 for ; Tue, 28 Feb 2023 14:38:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677623926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=EJkMR1yW1VwQXrb2e38VKDBxR+/bnLnE1QvDu6Bz41c=; b=aaiHvzyo5dKac1bZEMqVsUFiJ4VQSG/qoFP/7ffHSNLbMgacJirH0JA9tyJ8Dz9G9v88Xf h9jXeq/tD4CJTqgvf220CCE67a/WYBQnfx9m7NBgRh7kMXU6cqhoM3n3+II86pRb7vixUc LgH8dm8AC3C402z9orexybRrbsvKADg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-201-BVQoJkQ5ObCj-2C6iWfEpw-1; Tue, 28 Feb 2023 17:38:43 -0500 X-MC-Unique: BVQoJkQ5ObCj-2C6iWfEpw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5AFCF3810B07; Tue, 28 Feb 2023 22:38:42 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E66E2026D4B; Tue, 28 Feb 2023 22:38:40 +0000 (UTC) From: David Howells To: Steve French Cc: David Howells , Shyam Prasad N , Rohith Surabattula , Tom Talpey , Stefan Metzmacher , Jeff Layton , linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/1] smb3: Memory leak/page refcount overflow fix Date: Tue, 28 Feb 2023 22:38:37 +0000 Message-Id: <20230228223838.3794807-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Hi Steve, Here's another fix patch for you. It fixes a leak of the pages extracted for direct I/O. This was causing the page refcount to overflow and become negative and then try_grab_page() would always fail on it. I've pushed the patch here also: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=iov-cifs David David Howells (1): cifs: Fix memory leak in direct I/O fs/cifs/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)