mbox series

[v1,0/1] cifs: Release folio lock on fscache read hit.

Message ID 20230810071922.30229-1-russ@har.mn (mailing list archive)
Headers show
Series cifs: Release folio lock on fscache read hit. | expand

Message

Russell Harmon Aug. 10, 2023, 7:19 a.m. UTC
Here's a patch that fixes what seems to be a showstopping bug in
cifs-fscache. *Any time* that a fscache read hit occurs on a mounted
cifs filesystem (and therefore cifs_readpage_worker is called), the page
lock on the read page is leaked, causing subsequent accesses to the page
to deadlock.

I've been running my machine for the past week with this change and it
seems to work, but I'm a little concerned that this may mean
cifs-fscache has no users (besides me). Up to you (maintainers) whether
that means you should accept this patch... or delete the fscache
support.

Russell Harmon (1):
  cifs: Release folio lock on fscache read hit.

 fs/smb/client/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)