| Message ID | cover.1663125352.git.metze@samba.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | cifs: don't send uninitialized memory to sock_{send,recv}msg() | expand |
Reviewed by me for both patches On Wed, 14 Sept 2022 at 13:34, Stefan Metzmacher <metze@samba.org> wrote: > > Passing just half initialized struct msghdr variables down to > sock_{send,recv}msg() means we're waiting for a disater to happen... > > I added the removal of passing the destination address to > tcp as a separate patch in order to explain it separately. > > Stefan Metzmacher (2): > cifs: don't send down the destination address to sendmsg for a > SOCK_STREAM > cifs: always initialize struct msghdr smb_msg completely > > fs/cifs/connect.c | 11 +++-------- > fs/cifs/transport.c | 6 +----- > 2 files changed, 4 insertions(+), 13 deletions(-) > > -- > 2.34.1 >
Passing just half initialized struct msghdr variables down to sock_{send,recv}msg() means we're waiting for a disater to happen... I added the removal of passing the destination address to tcp as a separate patch in order to explain it separately. Stefan Metzmacher (2): cifs: don't send down the destination address to sendmsg for a SOCK_STREAM cifs: always initialize struct msghdr smb_msg completely fs/cifs/connect.c | 11 +++-------- fs/cifs/transport.c | 6 +----- 2 files changed, 4 insertions(+), 13 deletions(-)