[linux-cifs-client] Removed magic number for max username in parse_options.

Commit Message

Scott Lovenberg April 29, 2010, 1:58 p.m. UTC

None

Patch

diff --git a/mount.cifs.c b/mount.cifs.c
index 155d594..c1944ac 100644
--- a/mount.cifs.c
+++ b/mount.cifs.c
@@ -858,7 +858,11 @@  parse_options(const char *data, struct parsed_mount_info *parsed_info)
 					return EX_USAGE;
 				}
 			} else {
-				if (strnlen(value, 260) >= 260) {
+				/* domain/username%password */
+				const int max = MAX_DOMAIN_SIZE +
+						MAX_USERNAME_SIZE +
+						MOUNT_PASSWD_SIZE + 2;
+				if (strnlen(value, max + 1) >= max + 1) {
 					fprintf(stderr, "username too long\n");
 					return EX_USAGE;
 				}