From patchwork Tue Sep 25 10:52:46 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 1503811 Return-Path: X-Original-To: patchwork-cifs-client@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id A48D63FE65 for ; Tue, 25 Sep 2012 10:52:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751618Ab2IYKwx (ORCPT ); Tue, 25 Sep 2012 06:52:53 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:58372 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346Ab2IYKww (ORCPT ); Tue, 25 Sep 2012 06:52:52 -0400 Received: by yenm12 with SMTP id m12so1772596yen.19 for ; Tue, 25 Sep 2012 03:52:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=SNsdR4JYmH0tiG36W+5f4CTn9L+Q82yIkHGmJuCY3Fs=; b=U/uufGYBKgYkX3fzcsC9nMSeIy7e5JokCRLnNqkdINHvu7rr722rMlUo5PCXz/Pss1 1TVk3XlJs1zMKZ0Ug9m02qk61GVATxZmGbMrAXNUIui/ZpLR3cT/lj8DFCUGhT50JBLR g6QshvqV0wqvh/nb+eHcm9jF0tGnktq99jv+vebeJBI3poTifWMlTWqgNtdxpz5vChNi WyBMgXuF5AfB/Cl0Z5O7848Pho4qMtUeth5LNDHiFW5RxEcVGKs8IwNONvboG3MH4b4V Uy6KjzUnXzDohsswD92TpkpqZXx2Gu723IBemy87FoB6k5Tnx4uCBGzvMb1Sk19pQpKJ fcQQ== Received: by 10.236.191.233 with SMTP id g69mr15015048yhn.113.1348570371774; Tue, 25 Sep 2012 03:52:51 -0700 (PDT) Received: from salusa.poochiereds.net (cpe-069-134-145-027.nc.res.rr.com. [69.134.145.27]) by mx.google.com with ESMTPS id o25sm28715306yhm.14.2012.09.25.03.52.50 (version=SSLv3 cipher=OTHER); Tue, 25 Sep 2012 03:52:51 -0700 (PDT) From: Jeff Layton To: linux-cifs@vger.kernel.org Cc: walteste@inf.ethz.ch Subject: [PATCH] manpage: clarify the user of the username= option Date: Tue, 25 Sep 2012 06:52:46 -0400 Message-Id: <1348570366-17466-1-git-send-email-jlayton@samba.org> X-Mailer: git-send-email 1.7.11.4 X-Gm-Message-State: ALoCoQnuotxcfsQfWBMrRejq18ksTyx2Ka665a1ZHNJsLIZm1y3uuaz8MSZ/SlpwBF+Jt4O82fz3 Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Specifying the username as "user=" can confuse some versions of /bin/mount, and cause it to append noexec to the mount string. Also, remove the blurb about how cifs.ko will accept abbreviations -- it's just bad practice. A wonderful example of this confusion was reported by Stefan here: https://bugzilla.redhat.com/show_bug.cgi?id=860154 Reported-by: Stefan Walter Signed-off-by: Jeff Layton --- mount.cifs.8 | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/mount.cifs.8 b/mount.cifs.8 index cca6048..5629e84 100644 --- a/mount.cifs.8 +++ b/mount.cifs.8 @@ -52,33 +52,13 @@ command displays the version of cifs mount helper\&. command displays the version of cifs module\&. .SH "OPTIONS" .PP -user=\fIarg\fR +username=\fIarg\fR .RS 4 specifies the username to connect as\&. If this is not given, then the environment variable \fIUSER\fR is used\&. .PP -Earlier versions of mount.cifs also allowed one to specify the username in a "user%password" or "workgroup/user" or "workgroup/user%password" to allow the password and workgroup to be specified as part of the username. Support for those alternate username formats is now deprecated and should no longer be used. Users should use the discrete "pass=" and "dom=" to specify the username. -.if n \{\ -.sp -.\} -.RS 4 -.it 1 an-trap -.nr an-no-space-flag 1 -.nr an-break-flag 1 -.br -.ps +1 -\fBNote\fR -.ps -1 -.br -The cifs vfs accepts the parameter -\fIuser=\fR, or for users familiar with smbfs it accepts the longer form of the parameter -\fIusername=\fR\&. Similarly the longer smbfs style parameter names may be accepted as synonyms for the shorter cifs parameters -\fIpass=\fR,\fIdom=\fR -and -\fIcred=\fR\&. -.sp .5v -.RE +Earlier versions of mount.cifs also allowed one to specify the username in a "user%password" or "workgroup/user" or "workgroup/user%password" to allow the password and workgroup to be specified as part of the username. Support for those alternate username formats is now deprecated and should no longer be used. Users should use the discrete "password=" and "domain=" to specify those values. While some versions of the cifs kernel module accept "user=" as an abbreviation for this option, its use can confuse the standard mount program into thinking that this is a non-superuser mount. .RE .PP password=\fIarg\fR