| Message ID | 1350491389-8895-1-git-send-email-scott.lovenberg@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 17 Oct 2012 12:29:49 -0400 scott.lovenberg@gmail.com wrote: > From: Scott Lovenberg <scott.lovenberg@gmail.com> > > Signed-off-by: Scott Lovenberg <scott.lovenberg@gmail.com> > --- > mount.cifs.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/mount.cifs.c b/mount.cifs.c > index 756fce2..061ce32 100644 > --- a/mount.cifs.c > +++ b/mount.cifs.c > @@ -1335,6 +1335,7 @@ static int parse_unc(const char *unc_name, struct parsed_mount_info *parsed_info > } > > /* Set up "host" and "share" pointers based on UNC format. */ > + /* TODO: Remove support for NFS syntax as of cifs-utils-6.0. */ > if (strncmp(unc_name, "//", 2) && strncmp(unc_name, "\\\\", 2)) { > /* > * check for nfs syntax (server:/share/prepath) > @@ -1351,6 +1352,9 @@ static int parse_unc(const char *unc_name, struct parsed_mount_info *parsed_info > share++; > if (*share == '/') > ++share; > + fprintf(stderr, "WARNING: using NFS syntax for mounting CIFS " > + "shares is deprecated and will be removed in cifs-utils" > + "-6.0. Please migrate to UNC syntax."); > } else { > host = unc_name + 2; > hostlen = strcspn(host, "/\\"); Thanks, looks reasonable. I'll plan to pull it in for the next release unless there is objection...
On Wed, 17 Oct 2012 12:29:49 -0400 scott.lovenberg@gmail.com wrote: > From: Scott Lovenberg <scott.lovenberg@gmail.com> > > Signed-off-by: Scott Lovenberg <scott.lovenberg@gmail.com> > --- > mount.cifs.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/mount.cifs.c b/mount.cifs.c > index 756fce2..061ce32 100644 > --- a/mount.cifs.c > +++ b/mount.cifs.c > @@ -1335,6 +1335,7 @@ static int parse_unc(const char *unc_name, struct parsed_mount_info *parsed_info > } > > /* Set up "host" and "share" pointers based on UNC format. */ > + /* TODO: Remove support for NFS syntax as of cifs-utils-6.0. */ > if (strncmp(unc_name, "//", 2) && strncmp(unc_name, "\\\\", 2)) { > /* > * check for nfs syntax (server:/share/prepath) > @@ -1351,6 +1352,9 @@ static int parse_unc(const char *unc_name, struct parsed_mount_info *parsed_info > share++; > if (*share == '/') > ++share; > + fprintf(stderr, "WARNING: using NFS syntax for mounting CIFS " > + "shares is deprecated and will be removed in cifs-utils" > + "-6.0. Please migrate to UNC syntax."); > } else { > host = unc_name + 2; > hostlen = strcspn(host, "/\\"); Steve suggested resending this patch and cc'ing samba and samba-technical. Also, add a bit more explanation about why we're making this change so people are clear about why it's coming. You should also prefix the subject with something like "mount.cifs: " to make it clear what this patch is intended for. I think that's reasonable -- could you do that? Thanks,
On Wed, Oct 17, 2012 at 5:05 PM, Jeff Layton <jlayton@redhat.com> wrote: > Steve suggested resending this patch and cc'ing samba and > samba-technical. Also, add a bit more explanation about why we're > making this change so people are clear about why it's coming. > > You should also prefix the subject with something like "mount.cifs: " > to make it clear what this patch is intended for. > > I think that's reasonable -- could you do that? > > Thanks, > -- > Jeff Layton <jlayton@redhat.com> Not a problem. I'll take care of it tomorrow.
On 10/17/2012 11:45 PM, Scott Lovenberg wrote: > On Wed, Oct 17, 2012 at 5:05 PM, Jeff Layton<jlayton@redhat.com> wrote: > >> Steve suggested resending this patch and cc'ing samba and >> samba-technical. Also, add a bit more explanation about why we're >> making this change so people are clear about why it's coming. >> >> You should also prefix the subject with something like "mount.cifs: " >> to make it clear what this patch is intended for. >> >> I think that's reasonable -- could you do that? >> >> Thanks, >> -- >> Jeff Layton<jlayton@redhat.com> > > Not a problem. I'll take care of it tomorrow. Took care of that an hour or two ago. We'll see if anyone complains about the deprecation. If we don't hear anything in a day or so, I guess we can take that as an implicit ACK? -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 18 Oct 2012 15:20:06 -0400 Scott Lovenberg <scott.lovenberg@gmail.com> wrote: > On 10/17/2012 11:45 PM, Scott Lovenberg wrote: > > On Wed, Oct 17, 2012 at 5:05 PM, Jeff Layton<jlayton@redhat.com> wrote: > > > >> Steve suggested resending this patch and cc'ing samba and > >> samba-technical. Also, add a bit more explanation about why we're > >> making this change so people are clear about why it's coming. > >> > >> You should also prefix the subject with something like "mount.cifs: " > >> to make it clear what this patch is intended for. > >> > >> I think that's reasonable -- could you do that? > >> > >> Thanks, > >> -- > >> Jeff Layton<jlayton@redhat.com> > > > > Not a problem. I'll take care of it tomorrow. > Took care of that an hour or two ago. We'll see if anyone complains > about the deprecation. If we don't hear anything in a day or so, I > guess we can take that as an implicit ACK? I'd think so, yes...
diff --git a/mount.cifs.c b/mount.cifs.c index 756fce2..061ce32 100644 --- a/mount.cifs.c +++ b/mount.cifs.c @@ -1335,6 +1335,7 @@ static int parse_unc(const char *unc_name, struct parsed_mount_info *parsed_info } /* Set up "host" and "share" pointers based on UNC format. */ + /* TODO: Remove support for NFS syntax as of cifs-utils-6.0. */ if (strncmp(unc_name, "//", 2) && strncmp(unc_name, "\\\\", 2)) { /* * check for nfs syntax (server:/share/prepath) @@ -1351,6 +1352,9 @@ static int parse_unc(const char *unc_name, struct parsed_mount_info *parsed_info share++; if (*share == '/') ++share; + fprintf(stderr, "WARNING: using NFS syntax for mounting CIFS " + "shares is deprecated and will be removed in cifs-utils" + "-6.0. Please migrate to UNC syntax."); } else { host = unc_name + 2; hostlen = strcspn(host, "/\\");