From patchwork Fri Oct 19 12:14:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 1618211 Return-Path: X-Original-To: patchwork-cifs-client@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 108F5DF2AB for ; Fri, 19 Oct 2012 12:15:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751444Ab2JSMO7 (ORCPT ); Fri, 19 Oct 2012 08:14:59 -0400 Received: from mail-yh0-f46.google.com ([209.85.213.46]:34061 "EHLO mail-yh0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128Ab2JSMO7 (ORCPT ); Fri, 19 Oct 2012 08:14:59 -0400 Received: by mail-yh0-f46.google.com with SMTP id m54so43057yhm.19 for ; Fri, 19 Oct 2012 05:14:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=rvt0OUk/YrEsKUZGgQp3uVB1eC1g14pnWgqdBqBTuhQ=; b=cxjfgQLNxttVQBeu97veG6nFpKrpzQlmaZvtR2jJ9fjMeIAuK710uPuVZbmhKmd59y Q/nnGWA3Fqp9PjlPzJ3tHSPTKVGnMmAU5sVjbR6YCzuYvYC3gKau4StbQOUmeBSsROO0 6AdqiOfGax6R4bnkEraov8PYTnaXgPGStwRNzwx+DX+r9vIFDIJZHFu0ZpUj0N7wdZY5 T80rpXKBsKt54tZvBFAT2LipFaijEmDWaYWieZvYUlwYrV05XqUCl1cz6cNLfJ0XLjYe OXydiAvI9oQdzB2YOghS6AaXUEdGLqkb6gcizNFwMSwH7IMMQsKzI346M/kc+jOFKwpr DHVA== Received: by 10.236.77.74 with SMTP id c50mr876485yhe.43.1350648898393; Fri, 19 Oct 2012 05:14:58 -0700 (PDT) Received: from salusa.poochiereds.net (cpe-107-015-110-129.nc.res.rr.com. [107.15.110.129]) by mx.google.com with ESMTPS id z28sm1220442yhh.7.2012.10.19.05.14.56 (version=SSLv3 cipher=OTHER); Fri, 19 Oct 2012 05:14:57 -0700 (PDT) From: Jeff Layton To: smfrench@gmail.com Cc: linux-cifs@vger.kernel.org Subject: [PATCH] cifs: fix types on module parameters Date: Fri, 19 Oct 2012 08:14:52 -0400 Message-Id: <1350648892-5182-1-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.7.11.7 X-Gm-Message-State: ALoCoQkZovSYKH1wHEHcQLNgiTxi608WxPbFwi/FZUlcaZAFWkW5E+KbZ0aKhvptyOmvlGJBpNFM Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Most of these are unsigned ints, so we should be passing "uint" to module_param. Also, get rid of the extra "(bool)" in the description of enable_oplocks. Signed-off-by: Jeff Layton --- fs/cifs/cifsfs.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index e7931cc..07a8ab52 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c @@ -64,24 +64,23 @@ unsigned int global_secflags = CIFSSEC_DEF; unsigned int sign_CIFS_PDUs = 1; static const struct super_operations cifs_super_ops; unsigned int CIFSMaxBufSize = CIFS_MAX_MSGSIZE; -module_param(CIFSMaxBufSize, int, 0); +module_param(CIFSMaxBufSize, uint, 0); MODULE_PARM_DESC(CIFSMaxBufSize, "Network buffer size (not including header). " "Default: 16384 Range: 8192 to 130048"); unsigned int cifs_min_rcv = CIFS_MIN_RCV_POOL; -module_param(cifs_min_rcv, int, 0); +module_param(cifs_min_rcv, uint, 0); MODULE_PARM_DESC(cifs_min_rcv, "Network buffers in pool. Default: 4 Range: " "1 to 64"); unsigned int cifs_min_small = 30; -module_param(cifs_min_small, int, 0); +module_param(cifs_min_small, uint, 0); MODULE_PARM_DESC(cifs_min_small, "Small network buffers in pool. Default: 30 " "Range: 2 to 256"); unsigned int cifs_max_pending = CIFS_MAX_REQ; -module_param(cifs_max_pending, int, 0444); +module_param(cifs_max_pending, uint, 0444); MODULE_PARM_DESC(cifs_max_pending, "Simultaneous requests to server. " "Default: 32767 Range: 2 to 32767."); module_param(enable_oplocks, bool, 0644); -MODULE_PARM_DESC(enable_oplocks, "Enable or disable oplocks (bool). Default:" - "y/Y/1"); +MODULE_PARM_DESC(enable_oplocks, "Enable or disable oplocks. Default: y/Y/1"); extern mempool_t *cifs_sm_req_poolp; extern mempool_t *cifs_req_poolp;