From patchwork Wed Nov 28 11:27:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Shilovsky X-Patchwork-Id: 1815721 Return-Path: X-Original-To: patchwork-cifs-client@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 49D65DF26F for ; Wed, 28 Nov 2012 11:28:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754324Ab2K1L2H (ORCPT ); Wed, 28 Nov 2012 06:28:07 -0500 Received: from mail-lb0-f174.google.com ([209.85.217.174]:56910 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754244Ab2K1L2F (ORCPT ); Wed, 28 Nov 2012 06:28:05 -0500 Received: by mail-lb0-f174.google.com with SMTP id gi11so7478315lbb.19 for ; Wed, 28 Nov 2012 03:28:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:x-mailer; bh=m80JMKkgQZIfSKhPeDFvDYB6NTH+CKt4Z4abS1nYmZQ=; b=UgtNz5Ms0S5a7sE2gRDQB7bE0hTN4uVGjQ6j99s5FPhFWMPOfL+Z9aE3HQBk6UbKio 4fYGeXBKdq50C4/ZaAnFK75pLhswUHkFRWvR54bctOM6kcta/60Ujpg4zM/IwKmEdlDy 8yEKWGi2bwMrrrXhrFV7FgQ8HjqXS2MY1pBzy2QC5KwaUC8kzMLc3eyCuue+xdKQJz0+ fLAOH+zYM8FelQKm+Li51SQ7wqCg2cdwZmOrGgWwMU5khw1sc4l2/8We2fXWqghOGPtu eBlNBcdjDC7jYYtmFjGPtUpkgwtcXaiSJ+sfp4gPJClCLpNlybab0OIRIKBtaIPkaiLp pYJg== Received: by 10.112.44.161 with SMTP id f1mr7564815lbm.29.1354102084174; Wed, 28 Nov 2012 03:28:04 -0800 (PST) Received: from localhost.localdomain ([95.84.0.69]) by mx.google.com with ESMTPS id oj5sm7926574lab.8.2012.11.28.03.28.02 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 28 Nov 2012 03:28:03 -0800 (PST) From: Pavel Shilovsky To: linux-cifs@vger.kernel.org Subject: [PATCH] CIFS: Fix wrong buffer pointer usage in smb_set_file_info Date: Wed, 28 Nov 2012 15:27:54 +0400 Message-Id: <1354102074-24841-1-git-send-email-piastry@etersoft.ru> X-Mailer: git-send-email 1.7.10.4 Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Commit 6bdf6dbd662176c0da5c3ac8ed10ac94e7776c85 caused a regression in setattr codepath that leads to files with wrong attributes. Signed-off-by: Pavel Shilovsky Reviewed-by: Jeff Layton --- fs/cifs/smb1ops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/cifs/smb1ops.c b/fs/cifs/smb1ops.c index 77295f2..561547f 100644 --- a/fs/cifs/smb1ops.c +++ b/fs/cifs/smb1ops.c @@ -735,7 +735,6 @@ smb_set_file_info(struct inode *inode, const char *full_path, struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb); struct tcon_link *tlink = NULL; struct cifs_tcon *tcon; - FILE_BASIC_INFO info_buf; /* if the file is already open for write, just use that fileid */ open_file = find_writable_file(cinode, true); @@ -787,7 +786,7 @@ smb_set_file_info(struct inode *inode, const char *full_path, netpid = current->tgid; set_via_filehandle: - rc = CIFSSMBSetFileInfo(xid, tcon, &info_buf, netfid, netpid); + rc = CIFSSMBSetFileInfo(xid, tcon, buf, netfid, netpid); if (!rc) cinode->cifsAttrs = le32_to_cpu(buf->Attributes);