From patchwork Fri Nov 30 10:20:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Shilovsky X-Patchwork-Id: 1824491 Return-Path: X-Original-To: patchwork-cifs-client@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id B6854DFABE for ; Fri, 30 Nov 2012 10:21:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757233Ab2K3KU7 (ORCPT ); Fri, 30 Nov 2012 05:20:59 -0500 Received: from mail-la0-f46.google.com ([209.85.215.46]:43174 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753993Ab2K3KU4 (ORCPT ); Fri, 30 Nov 2012 05:20:56 -0500 Received: by mail-la0-f46.google.com with SMTP id p5so216649lag.19 for ; Fri, 30 Nov 2012 02:20:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:x-mailer:in-reply-to :references; bh=OSgBjZomjJh0FArPwAyYtWBJ2jXw68I8nUkl2V6Gt1s=; b=yfnYW5IaeWrwi+xiLbtDBTv4F1MrfXpV0rxuxDIQH3Gx92Z9l/U2R01DAhh9QPH0u+ nvTodFLKnvPvveuktM/WWOid4J+vtZgeD1ywKiBIkqnj9qjhNRWapGHzcS+QTcQ+7Skb 7lPPg991oQLcNrFLzeo48t2ANfFhUpZrV+if0gCbyVHQHw7lqXLlFqqyLnUia7vwRtiw PIpGfxDUqRIh5MkON6MOJWZq9d2AAIUJo6FMXE5qU81SdBm36nUYznMP1jE5x5L1Qv1s /0PQy6aIn0avPGzfLsk+BDNciHXaFagZCeReQJZGfI2bc7q9kB4y0dyFJ8IDQYUgoCwz rEGA== Received: by 10.112.16.106 with SMTP id f10mr659855lbd.1.1354270855523; Fri, 30 Nov 2012 02:20:55 -0800 (PST) Received: from localhost.localdomain ([95.84.0.69]) by mx.google.com with ESMTPS id gr12sm1805391lab.3.2012.11.30.02.20.53 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 30 Nov 2012 02:20:54 -0800 (PST) From: Pavel Shilovsky To: linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH 3/3] CIFS: Use NT_CREATE_ANDX command for forcemand mounts Date: Fri, 30 Nov 2012 14:20:40 +0400 Message-Id: <1354270840-7272-4-git-send-email-piastry@etersoft.ru> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1354270840-7272-1-git-send-email-piastry@etersoft.ru> References: <1354270840-7272-1-git-send-email-piastry@etersoft.ru> Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org forcemand mount option now lets us use Windows mandatory style of byte-range locks even if server supports posix ones - switches on Windows locking mechanism. Share flags is another locking mehanism provided by Windows semantic that can be used by NT_CREATE_ANDX command. This patch combines all Windows locking mechanism in one mount option by using NT_CREATE_ANDX to open files if forcemand is on. Signed-off-by: Pavel Shilovsky --- fs/cifs/dir.c | 1 + fs/cifs/file.c | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index 4784d53..8edd950 100644 --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c @@ -216,6 +216,7 @@ cifs_do_create(struct inode *inode, struct dentry *direntry, unsigned int xid, } if (tcon->unix_ext && cap_unix(tcon->ses) && !tcon->broken_posix_open && + ((cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NOPOSIXBRL) == 0) && (CIFS_UNIX_POSIX_PATH_OPS_CAP & le64_to_cpu(tcon->fsUnixInfo.Capability))) { rc = cifs_posix_open(full_path, &newinode, inode->i_sb, mode, diff --git a/fs/cifs/file.c b/fs/cifs/file.c index e2614b9..8cfda53 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -426,8 +426,9 @@ int cifs_open(struct inode *inode, struct file *file) else oplock = 0; - if (!tcon->broken_posix_open && tcon->unix_ext && - cap_unix(tcon->ses) && (CIFS_UNIX_POSIX_PATH_OPS_CAP & + if (!tcon->broken_posix_open && tcon->unix_ext && cap_unix(tcon->ses) + && ((cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NOPOSIXBRL) == 0) && + (CIFS_UNIX_POSIX_PATH_OPS_CAP & le64_to_cpu(tcon->fsUnixInfo.Capability))) { /* can not refresh inode info since size could be stale */ rc = cifs_posix_open(full_path, &inode, inode->i_sb, @@ -595,6 +596,7 @@ cifs_reopen_file(struct cifsFileInfo *cfile, bool can_flush) oplock = 0; if (tcon->unix_ext && cap_unix(tcon->ses) && + ((cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NOPOSIXBRL) == 0) && (CIFS_UNIX_POSIX_PATH_OPS_CAP & le64_to_cpu(tcon->fsUnixInfo.Capability))) { /*