From patchwork Tue Dec 18 11:48:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 1891351 Return-Path: X-Original-To: patchwork-cifs-client@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id A66D03FC64 for ; Tue, 18 Dec 2012 11:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754094Ab2LRLso (ORCPT ); Tue, 18 Dec 2012 06:48:44 -0500 Received: from mail-gg0-f174.google.com ([209.85.161.174]:43840 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754066Ab2LRLsn (ORCPT ); Tue, 18 Dec 2012 06:48:43 -0500 Received: by mail-gg0-f174.google.com with SMTP id k2so83823ggd.5 for ; Tue, 18 Dec 2012 03:48:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=b4U1LAzwaGodWGZWRuE3tyYTDiO9HTh7CoD+vpb5H0k=; b=K5N+0zCSHwvJoRQDC7HcmuWQKRKVKkOo3dS3eCqefxkx2udjVPdv8AWYaqPzdEifoz ddBfHQPmWkKMVL8aO7eK5VvNIjHqKXubBdH8u7FdwSW7dWv74G+RtxCYVVNAcqEtuoHl HfGMjPdqzqu5/6NsvYghb1K0YYHiw5UK5k3AsDkFmQk/TMOJgZw+7pML/AiBc2V8ydeN Qgn7YzY3jmo6TeKsAfbHt5lcoiQMziDv0y+ZNaPJI+YJF1mZqgLBLv82qHcvA90CEkuf WWLsT0rthXE/YwvF1mXdt+9y7yWVLoVjCe4Q8j2cDrlCzq9tNU1j/kchJwk5q0VOUt3a JB4Q== X-Received: by 10.236.135.238 with SMTP id u74mr1470081yhi.52.1355831323242; Tue, 18 Dec 2012 03:48:43 -0800 (PST) Received: from salusa.poochiereds.net (cpe-107-015-113-143.nc.res.rr.com. [107.15.113.143]) by mx.google.com with ESMTPS id u8sm1256645yhi.3.2012.12.18.03.48.41 (version=SSLv3 cipher=OTHER); Tue, 18 Dec 2012 03:48:42 -0800 (PST) From: Jeff Layton To: smfrench@gmail.com Cc: linux-cifs@vger.kernel.org Subject: [PATCH] cifs: eliminate cifsERROR variable Date: Tue, 18 Dec 2012 06:48:37 -0500 Message-Id: <1355831317-21985-1-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.7.11.7 X-Gm-Message-State: ALoCoQkhQ3BneDixa0CphupDK0SjdqvULdp9WCuyjFGe1nyekZlTeewxtWsCVmSi3E7bm1K83Otp Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org It's always set to "1" and there's no way to change it to anything else. Signed-off-by: Jeff Layton --- fs/cifs/cifs_debug.h | 6 +----- fs/cifs/cifsfs.c | 1 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/cifs/cifs_debug.h b/fs/cifs/cifs_debug.h index 86e92ef..69ae3d3 100644 --- a/fs/cifs/cifs_debug.h +++ b/fs/cifs/cifs_debug.h @@ -37,7 +37,6 @@ void dump_smb(void *, int); #define CIFS_TIMER 0x04 extern int cifsFYI; -extern int cifsERROR; /* * debug ON @@ -64,10 +63,7 @@ do { \ /* error event message: e.g., i/o error */ #define cifserror(fmt, ...) \ -do { \ - if (cifsERROR) \ - printk(KERN_ERR "CIFS VFS: " fmt "\n", ##__VA_ARGS__); \ -} while (0) + printk(KERN_ERR "CIFS VFS: " fmt "\n", ##__VA_ARGS__); \ #define cERROR(set, fmt, ...) \ do { \ diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index ce9f3c5..f653835 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c @@ -54,7 +54,6 @@ #endif int cifsFYI = 0; -int cifsERROR = 1; int traceSMB = 0; bool enable_oplocks = true; unsigned int linuxExtEnabled = 1;