diff mbox

[2/2] cifs: Expand max share name length to 256

Message ID 1374773721-24394-2-git-send-email-scott.lovenberg@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Scott Lovenberg July 25, 2013, 5:35 p.m. UTC
From: Scott Lovenberg <scott.lovenberg@gmail.com>

The old max share name length limit was 80 due to Windows NET SHARE
command not allowing more than that.  However, share names can be much
longer.  This is a more reasonable maximum share name length.

Signed-off-by: Scott Lovenberg <scott.lovenberg@gmail.com>
---
 include/uapi/linux/cifs/cifs_mount.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jeff Layton July 25, 2013, 5:45 p.m. UTC | #1
On Thu, 25 Jul 2013 13:35:21 -0400
scott.lovenberg@gmail.com wrote:

> From: Scott Lovenberg <scott.lovenberg@gmail.com>
> 
> The old max share name length limit was 80 due to Windows NET SHARE
> command not allowing more than that.  However, share names can be much
> longer.  This is a more reasonable maximum share name length.
> 
> Signed-off-by: Scott Lovenberg <scott.lovenberg@gmail.com>
> ---
>  include/uapi/linux/cifs/cifs_mount.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/cifs/cifs_mount.h b/include/uapi/linux/cifs/cifs_mount.h
> index 1485781..f7e4aee 100644
> --- a/include/uapi/linux/cifs/cifs_mount.h
> +++ b/include/uapi/linux/cifs/cifs_mount.h
> @@ -20,6 +20,6 @@
>  #define CIFS_MAX_DOMAINNAME_LEN 256 /* max fully qualified domain name */
>  #define CIFS_MAX_USERNAME_LEN   256 /* reasonable max for current servers */
>  #define CIFS_MAX_PASSWORD_LEN   512 /* Windows max seems to be 256 wide chars */
> -#define CIFS_MAX_SHARE_LEN 80
> +#define CIFS_MAX_SHARE_LEN      256 /* reasonable max share name length */
>  
>  #endif /* _CIFS_MOUNT_H */

Looks good...

Reviewed-by: Jeff Layton <jlayton@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/uapi/linux/cifs/cifs_mount.h b/include/uapi/linux/cifs/cifs_mount.h
index 1485781..f7e4aee 100644
--- a/include/uapi/linux/cifs/cifs_mount.h
+++ b/include/uapi/linux/cifs/cifs_mount.h
@@ -20,6 +20,6 @@ 
 #define CIFS_MAX_DOMAINNAME_LEN 256 /* max fully qualified domain name */
 #define CIFS_MAX_USERNAME_LEN   256 /* reasonable max for current servers */
 #define CIFS_MAX_PASSWORD_LEN   512 /* Windows max seems to be 256 wide chars */
-#define CIFS_MAX_SHARE_LEN 80
+#define CIFS_MAX_SHARE_LEN      256 /* reasonable max share name length */
 
 #endif /* _CIFS_MOUNT_H */