From patchwork Tue Sep 17 11:08:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 2901871 Return-Path: X-Original-To: patchwork-cifs-client@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6E04FBFF05 for ; Tue, 17 Sep 2013 11:08:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6C45420377 for ; Tue, 17 Sep 2013 11:08:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C0802020F for ; Tue, 17 Sep 2013 11:08:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197Ab3IQLIR (ORCPT ); Tue, 17 Sep 2013 07:08:17 -0400 Received: from mail-ve0-f174.google.com ([209.85.128.174]:53821 "EHLO mail-ve0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982Ab3IQLIR (ORCPT ); Tue, 17 Sep 2013 07:08:17 -0400 Received: by mail-ve0-f174.google.com with SMTP id jy13so3911929veb.19 for ; Tue, 17 Sep 2013 04:08:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=8qhb3ipckO3HgeAZb1HEODFt3aWBfTChtDl4LqF2oeA=; b=UX36tzYNFtp2NmQpn5dW52Ym/Yi+9Ut/IBZRf5qgIPbb6MOpL0t1cV9Tq/rA5lNjKF aBKImgKdjcac3OOgW7JpPJ1SVzzTK9uXLxoD4F5wnqk78BglhOx46CzLswL3YYBSIjaH xNMdDr1Zq+T8EblNa0bivbNkHiVnOrAXfFCI7OTxqYmTBTOcPQYwUw+V2gLzcqFDWtda bEDWoEw3uyzSaBxfmY5QGabbAhSrrHw5INq8a4aNqwTHYP3bfr4khcOkrhVKph1ovCfc lpvCZX4x7X7DF8qh0T/H5aSyDBfLyidhxxHNlzLOAK8LqE4v0leFRTIjK5ZMmvAJq91i zyLw== X-Gm-Message-State: ALoCoQk6yhna8giOl20Qj895iATQBLNwjfY+7oY0gGSAl9r5Lb9h6MPpDBO/Bp9G6Oxth4XEEd3D X-Received: by 10.221.64.17 with SMTP id xg17mr31804105vcb.5.1379416096547; Tue, 17 Sep 2013 04:08:16 -0700 (PDT) Received: from salusa.poochiereds.net (cpe-107-015-124-230.nc.res.rr.com. [107.15.124.230]) by mx.google.com with ESMTPSA id c16sm23579892vdj.12.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 17 Sep 2013 04:08:15 -0700 (PDT) From: Jeff Layton To: smfrench@gmail.com Cc: linux-cifs@vger.kernel.org, "Andrey Shernyukov" Subject: [PATCH] cifs: don't spam the logs on unexpected lookup errors Date: Tue, 17 Sep 2013 07:08:11 -0400 Message-Id: <1379416091-2040-1-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Andrey reported that he was seeing cifs.ko spam the logs with messages like this: CIFS VFS: Unexpected lookup error -26 He was listing the root directory of a server and hitting an error when trying to QUERY_PATH_INFO against hiberfil.sys and pagefile.sys. The right fix would be to switch the lookup code over to using FIND_FIRST, but until then we really don't need to report this at a level of KERN_ERR. Convert this message over to FYI level. Reported-by: "Andrey Shernyukov" Signed-off-by: Jeff Layton --- fs/cifs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index d3e2eaa..55c38cf 100644 --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c @@ -755,7 +755,7 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry, /* if it was once a directory (but how can we tell?) we could do shrink_dcache_parent(direntry); */ } else if (rc != -EACCES) { - cifs_dbg(VFS, "Unexpected lookup error %d\n", rc); + cifs_dbg(FYI, "Unexpected lookup error %d\n", rc); /* We special case check for Access Denied - since that is a common return code */ }