From patchwork Thu Nov 7 20:03:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 3154301 Return-Path: X-Original-To: patchwork-cifs-client@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8B6E7BEEB2 for ; Thu, 7 Nov 2013 20:03:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 71FAE20490 for ; Thu, 7 Nov 2013 20:03:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 337AB20481 for ; Thu, 7 Nov 2013 20:03:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752781Ab3KGUDp (ORCPT ); Thu, 7 Nov 2013 15:03:45 -0500 Received: from mail-qc0-f175.google.com ([209.85.216.175]:44641 "EHLO mail-qc0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752711Ab3KGUDp (ORCPT ); Thu, 7 Nov 2013 15:03:45 -0500 Received: by mail-qc0-f175.google.com with SMTP id e16so871739qcx.6 for ; Thu, 07 Nov 2013 12:03:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=G46BANn2tyowM0sDJvGdLIZEfoH8l8aymbzpzKMZdTg=; b=CuUQtFiUS9VZ39MqqooommcUbbCCJveKagYum4B4v4F9uuLc3Bn/lE9kT/hQNDNgDz DFLFkGipQfyikizZCpFNNHtbobLMtmXnQjmgVV/LDei4WYIpmYupcPDxGurhvcA589+5 dsxWaSyqdpq67nCq+v1ZF9lxOUn7f1mau1PnCye9Y2XwrS7jJ+ddDNKPZeae8icE6IRN EUcI4vRRf0bzXf2hTdqK/n2Xi1yrAzc/pX6tVBmn8wPiKcutoxkzbJ5WlkBXLFOFwZjo PIZsDU8NLehSHQjEQKHvG9Y5pem74rjYcZ2FbaFFnUAz3hmo9PzJxOVKa1nUpG4+ZRgv Nc0Q== X-Gm-Message-State: ALoCoQlqwpo/E1EJd2XS2rhSQAq6uj5G4F0HS+EJZeTdIOjmWkx9EjkCQzB3h+jy7hGg5SD71sg+ X-Received: by 10.224.70.10 with SMTP id b10mr17700159qaj.28.1383854624889; Thu, 07 Nov 2013 12:03:44 -0800 (PST) Received: from salusa.poochiereds.net (cpe-107-015-124-230.nc.res.rr.com. [107.15.124.230]) by mx.google.com with ESMTPSA id n7sm13482500qai.1.2013.11.07.12.03.43 for (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128); Thu, 07 Nov 2013 12:03:44 -0800 (PST) From: Jeff Layton To: smfrench@gmail.com Cc: linux-cifs@vger.kernel.org, andreysh@nioch.nsc.ru Subject: [PATCH][resend] cifs: don't spam the logs on unexpected lookup errors Date: Thu, 7 Nov 2013 15:03:39 -0500 Message-Id: <1383854619-12109-1-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Andrey reported that he was seeing cifs.ko spam the logs with messages like this: CIFS VFS: Unexpected lookup error -26 He was listing the root directory of a server and hitting an error when trying to QUERY_PATH_INFO against hiberfil.sys and pagefile.sys. The right fix would be to switch the lookup code over to using FIND_FIRST, but until then we really don't need to report this at a level of KERN_ERR. Convert this message over to FYI level. Reported-by: "Andrey Shernyukov" Signed-off-by: Jeff Layton --- fs/cifs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index 5384c2a..11ff5f1 100644 --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c @@ -756,7 +756,7 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry, /* if it was once a directory (but how can we tell?) we could do shrink_dcache_parent(direntry); */ } else if (rc != -EACCES) { - cifs_dbg(VFS, "Unexpected lookup error %d\n", rc); + cifs_dbg(FYI, "Unexpected lookup error %d\n", rc); /* We special case check for Access Denied - since that is a common return code */ }