diff mbox

[v2] cifs: Stop using NTLMSSP flag bit NTLMSSP_NEGOTIATE_EXTENDED_SEC for key exchange

Message ID 1395347226-9184-1-git-send-email-spargaonkar@suse.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shirish Pargaonkar March 20, 2014, 8:27 p.m. UTC 
From: Shirish Pargaonkar <spargaonkar@suse.com>


Send EncryptedRandomSessionKey in an Authenticate message of NTLMSSP exchange
based only on whether server set flag bit NTLMSSP_NEGOTIATE_KEY_EXCH in the
Challenge message of the NTLMSSP exchange.

This is per section of MS-NLMP.
3.1.5.1.2 Client Receives a CHALLENGE_MESSAGE from the Server


Reported-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Shirish Pargaonkar <spargaonkar@suse.com>
---
 fs/cifs/sess.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff mbox

Patch

diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c
index e87387d..1bd6f4f 100644
--- a/fs/cifs/sess.c
+++ b/fs/cifs/sess.c
@@ -450,8 +450,7 @@  int build_ntlmssp_auth_blob(unsigned char *pbuffer,
 	sec_blob->WorkstationName.MaximumLength = 0;
 	tmp += 2;
 
-	if (((ses->ntlmssp->server_flags & NTLMSSP_NEGOTIATE_KEY_XCH) ||
-		(ses->ntlmssp->server_flags & NTLMSSP_NEGOTIATE_EXTENDED_SEC))
+	if ((ses->ntlmssp->server_flags & NTLMSSP_NEGOTIATE_KEY_XCH)
 			&& !calc_seckey(ses)) {
 		memcpy(tmp, ses->ntlmssp->ciphertext, CIFS_CPHTXT_SIZE);
 		sec_blob->SessionKey.BufferOffset = cpu_to_le32(tmp - pbuffer);