From patchwork Sun Aug 10 20:51:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 4705121 Return-Path: X-Original-To: patchwork-cifs-client@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 378269F375 for ; Sun, 10 Aug 2014 20:52:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7A398201B9 for ; Sun, 10 Aug 2014 20:52:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 975FA20173 for ; Sun, 10 Aug 2014 20:52:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751727AbaHJUv4 (ORCPT ); Sun, 10 Aug 2014 16:51:56 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:41834 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbaHJUvz (ORCPT ); Sun, 10 Aug 2014 16:51:55 -0400 Received: by mail-wi0-f174.google.com with SMTP id d1so3319062wiv.7 for ; Sun, 10 Aug 2014 13:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=90k+ckF+LundzmUZsy6IXDq3NTb6PBswmaqbYbD91DI=; b=xwCHfwgVMPfJjzjx76PeaxPcQCD6GRJLl1I9lWDyU6yRitOmILAEyFV89JiHFHym9J v/AYjKpVveVc4wOMQqW4oHKbypVB0HZ2LvQoq65Z4hOpSFWzuwuFA69MwqKeIKhgEQp8 hGArxeOoyrW4nkzmR7EBjo9ZK0S++2BxyNiW/Q/n45KpYN5wkld0H7EX69j6OhzgWa61 BSNjAIoI+4YDHKPVuh5zOLUzC9ApeiLUxzZScs1UgI0U3h6fJae7mnyoif63hCrqgluw KSahLba8okyc0pfbhSTcrC1tEt+HCSOy+yuobP2s0Y/hdy6Rd+uXu7UP+cDR72v4fORB ydrg== X-Received: by 10.180.101.129 with SMTP id fg1mr20039877wib.20.1407703913692; Sun, 10 Aug 2014 13:51:53 -0700 (PDT) Received: from ramsan.of.borg (d54C154A7.access.telenet.be. [84.193.84.167]) by mx.google.com with ESMTPSA id u5sm35120535wia.17.2014.08.10.13.51.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 10 Aug 2014 13:51:52 -0700 (PDT) From: Geert Uytterhoeven To: Steve French , Sachin Prabhu Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 1/2] cifs: Remove unused sess_auth_lanman() for !CONFIG_CIFS_WEAK_PW_HASH case Date: Sun, 10 Aug 2014 22:51:48 +0200 Message-Id: <1407703909-24350-1-git-send-email-geert@linux-m68k.org> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If CONFIG_CIFS_WEAK_PW_HASH is not set: fs/cifs/sess.c:751: warning: ‘sess_auth_lanman’ defined but not used Commit cc87c47d9d7ac25554aa81cd8ded56e75f79c198 ("cifs: Separate rawntlmssp auth from CIFS_SessSetup()") removed the sole user of the dummy version of sess_auth_lanman() in the non-CONFIG_CIFS_WEAK_PW_HASH case, but forgot to remove the actual function definition. Remove the dummy version to fix this. Signed-off-by: Geert Uytterhoeven --- fs/cifs/sess.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c index 39ee32688eac..8090ad3c5ea5 100644 --- a/fs/cifs/sess.c +++ b/fs/cifs/sess.c @@ -743,16 +743,7 @@ out: sess_data->func = NULL; sess_free_buffer(sess_data); } - -#else - -static void -sess_auth_lanman(struct sess_data *sess_data) -{ - sess_data->result = -EOPNOTSUPP; - sess_data->func = NULL; -} -#endif +#endif /* CONFIG_CIFS_WEAK_PW_HASH */ static void sess_auth_ntlm(struct sess_data *sess_data)