From patchwork Thu Aug 25 14:17:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 9299447 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 762E160757 for ; Thu, 25 Aug 2016 14:42:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6765D28E12 for ; Thu, 25 Aug 2016 14:42:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5C05F28E9C; Thu, 25 Aug 2016 14:42:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E887328E12 for ; Thu, 25 Aug 2016 14:42:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754922AbcHYOm2 (ORCPT ); Thu, 25 Aug 2016 10:42:28 -0400 Received: from hr2.samba.org ([144.76.82.148]:30341 "EHLO hr2.samba.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755198AbcHYOm2 (ORCPT ); Thu, 25 Aug 2016 10:42:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=samba.org; s=42627210; h=Message-Id:Date:Cc:To:From; bh=ol+Fn0Ym0OvEUGjkZIB5HMDPAc8JK0n4JTS0YgzE02o=; b=OoiQih15uGgMCmq27RgFLPmtrtHQ43jBsG8erz8s1l6n3xkAruxOjGnPmzt2qD1R9oId7JGpnPYHO+t3iLFz3nBswsGhcmmGnMWNLlBo+bZXpOrIPeLjqqVRKxMquZRPPC8MEECjsfo1q02dk+c09y8DWmobdgibMYU4jyPndz0=; Received: from [127.0.0.2] (localhost [127.0.0.1]) by hr2.samba.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1bcvTy-0001dI-Uw; Thu, 25 Aug 2016 14:18:15 +0000 From: Jeff Layton To: linux-cifs@vger.kernel.org Cc: samba-technical@lists.samba.org, jfdey@fredhutch.org Subject: [cifs-utils PATCHv2 4/6] cifs.upcall: remove KRB5_TC_OPENCLOSE Date: Thu, 25 Aug 2016 10:17:43 -0400 Message-Id: <1472134665-4014-5-git-send-email-jlayton@samba.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1472134665-4014-1-git-send-email-jlayton@samba.org> References: <1472134665-4014-1-git-send-email-jlayton@samba.org> Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The header file says that this is deprecated, and all of the info I've seen about it mentioned that it was for performance more than correctness. It dates back to the original code dump from Igor, so I think we're safe to just drop it at this point. Signed-off-by: Jeff Layton --- cifs.upcall.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/cifs.upcall.c b/cifs.upcall.c index 8448d00f6061..a25833592440 100644 --- a/cifs.upcall.c +++ b/cifs.upcall.c @@ -157,9 +157,6 @@ err_endseq: err_ccstart: krb5_free_principal(context, principal); err_princ: -#if defined(KRB5_TC_OPENCLOSE) - krb5_cc_set_flags(context, ccache, KRB5_TC_OPENCLOSE); -#endif krb5_cc_close(context, ccache); err_cache: return credtime; @@ -388,9 +385,6 @@ out_free_creds: out_free_principal: krb5_free_principal(context, in_creds.client); out_free_ccache: -#if defined(KRB5_TC_OPENCLOSE) - krb5_cc_set_flags(context, ccache, KRB5_TC_OPENCLOSE); -#endif krb5_cc_close(context, ccache); return ret; }