From patchwork Wed Jun 28 17:50:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Long Li X-Patchwork-Id: 9814959 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EA38360365 for ; Wed, 28 Jun 2017 17:51:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D732B285FF for ; Wed, 28 Jun 2017 17:51:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CB4A228600; Wed, 28 Jun 2017 17:51:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6AF9A285FC for ; Wed, 28 Jun 2017 17:51:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751659AbdF1Rvx (ORCPT ); Wed, 28 Jun 2017 13:51:53 -0400 Received: from a2nlsmtp01-02.prod.iad2.secureserver.net ([198.71.225.36]:55372 "EHLO a2nlsmtp01-02.prod.iad2.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbdF1Rvw (ORCPT ); Wed, 28 Jun 2017 13:51:52 -0400 Received: from linuxonhyperv.com ([107.180.71.197]) by : HOSTING RELAY : with SMTP id QH6odB1QA9MhGQH6odV0EO; Wed, 28 Jun 2017 10:50:45 -0700 x-originating-ip: 107.180.71.197 Received: from longli by linuxonhyperv.com with local (Exim 4.89) (envelope-from ) id 1dQH6o-0007vd-Qe; Wed, 28 Jun 2017 10:50:34 -0700 From: Long Li To: Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org Cc: Long Li Subject: [PATCH] cifs: Do not modify mid entry after submitting I/O in cifs_call_async Date: Wed, 28 Jun 2017 10:50:02 -0700 Message-Id: <1498672202-30452-1-git-send-email-longli@exchange.microsoft.com> X-Mailer: git-send-email 1.7.1 X-CMAE-Envelope: MS4wfOF6BHpgjR1e9GsvllgWDVEIURra93vZvHsEgrOZfQgZXKjG+edJFVB4T8spCDnVZXgnMliGeKOrdPjyn6rOQGGYMRVsnHjMcTIoF9sa9oSXrtaFIYsr GV7R7aJcTQoEuts0joMdXJ5e6C54eIz3jFKN3PeJOzD2GIe12H0+auyJ/7/kQ+seyIy0oohXXdOCSmVi+odQCRw+0cy5eYr+2FW9Ohl4zEHhTK56lafmtEWE g9hQGGaojcKpevk70epvWjbJbl26hTjONl8lWN7880QmWQYcp+HMozxCpibe2FJZB188DAyA1ssXjrH5dthYODBhawOmWmi7hnQ9lF5G9Uw= Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Long Li In cifs_call_async, server response may return as soon as I/O is submitted. Do not touch it after that. Signed-off-by: Long Li --- fs/cifs/transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index 47a125e..ba62aaf 100644 --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c @@ -537,10 +537,10 @@ cifs_call_async(struct TCP_Server_Info *server, struct smb_rqst *rqst, spin_unlock(&GlobalMid_Lock); + cifs_save_when_sent(mid); cifs_in_send_inc(server); rc = smb_send_rqst(server, rqst, flags); cifs_in_send_dec(server); - cifs_save_when_sent(mid); if (rc < 0) { server->sequence_number -= 2;