[07/23] CIFS: Do not log credits when unmounting a share

Message ID	1549051452-5968-8-git-send-email-pshilov@microsoft.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <linux-cifs-owner@kernel.org> From: Pavel Shilovsky <piastryyy@gmail.com> To: linux-cifs@vger.kernel.org Subject: [PATCH 07/23] CIFS: Do not log credits when unmounting a share Date: Fri, 1 Feb 2019 12:03:55 -0800 Message-Id: <1549051452-5968-8-git-send-email-pshilov@microsoft.com> In-Reply-To: <1549051452-5968-1-git-send-email-pshilov@microsoft.com> References: <1549051452-5968-1-git-send-email-pshilov@microsoft.com> Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk
Series	Improve credits and error handling on reconnects \| expand [00/23] Improve credits and error handling on reconnects [01/23] CIFS: Fix possible oops and memory leaks in async IO [02/23] CIFS: Fix trace command logging for SMB2 reads and writes [03/23] CIFS: Do not count -ENODATA as failure for query directory [04/23] CIFS: Do not consider -ENODATA as stat failure for reads [05/23] CIFS: Fix leaking locked VFS cache pages in writeback retry [06/23] CIFS: Always reset read error to -EIO if no response [07/23] CIFS: Do not log credits when unmounting a share [08/23] CIFS: Count credits for malformed error pending responses [09/23] CIFS: Respect SMB2 hdr preamble size in read responses [10/23] CIFS: Mask signals during sock_sendmsg() [11/23] CIFS: Set reconnect instance to one initially [12/23] CIFS: Respect reconnect in MTU credits calculations [13/23] CIFS: Respect reconnect in non-MTU credits calculations [14/23] CIFS: Check for reconnects before sending async requests [15/23] CIFS: Check for reconnects before sending compound requests [16/23] CIFS: Adjust MTU credits before reopening a file [17/23] CIFS: Remove custom credit adjustments for SMB2 async IO [18/23] CIFS: Reopen file before get SMB2 MTU credits for async IO [19/23] CIFS: Find and reopen a file before get MTU credits in writepages [20/23] CIFS: Move unlocking pages from wdata_send_pages() [21/23] CIFS: Move open file handling to writepages [22/23] CIFS: Return error code when getting file handle for writeback [23/23] CIFS: Try to acquire credits at once for compound requests

Message ID

1549051452-5968-8-git-send-email-pshilov@microsoft.com (mailing list archive)

State

New, archived

Headers

From: Pavel Shilovsky <piastryyy@gmail.com>
To: linux-cifs@vger.kernel.org
Subject: [PATCH 07/23] CIFS: Do not log credits when unmounting a share
Date: Fri,  1 Feb 2019 12:03:55 -0800
Message-Id: <1549051452-5968-8-git-send-email-pshilov@microsoft.com>
In-Reply-To: <1549051452-5968-1-git-send-email-pshilov@microsoft.com>
References: <1549051452-5968-1-git-send-email-pshilov@microsoft.com>
Sender: linux-cifs-owner@vger.kernel.org
Precedence: bulk

Series

Improve credits and error handling on reconnects | expand

Commit Message

Pavel Shilovsky Feb. 1, 2019, 8:03 p.m. UTC

Currently we only skip credits logging on reconnects. When
unmounting a share the number of credits on the client doesn't
matter, so skip logging in such cases too.

Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/smb2ops.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index 6f96e22..49667ae 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -102,7 +102,8 @@  smb2_add_credits(struct TCP_Server_Info *server, const unsigned int add,
 	spin_unlock(&server->req_lock);
 	wake_up(&server->request_q);
 
-	if (server->tcpStatus == CifsNeedReconnect)
+	if (server->tcpStatus == CifsNeedReconnect
+	    || server->tcpStatus == CifsExiting)
 		return;
 
 	switch (rc) {

[07/23] CIFS: Do not log credits when unmounting a share

Commit Message

Patch