From patchwork Wed Jun 10 14:09:06 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 29299 Received: from lists.samba.org (mail.samba.org [66.70.73.150]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n5AEB86q003963 for ; Wed, 10 Jun 2009 14:11:08 GMT Received: from dp.samba.org (localhost [127.0.0.1]) by lists.samba.org (Postfix) with ESMTP id 252F8163CDC for ; Wed, 10 Jun 2009 14:10:36 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on dp.samba.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.8 tests=AWL,BAYES_00, FORGED_RCVD_HELO,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.1.7 X-Original-To: linux-cifs-client@lists.samba.org Delivered-To: linux-cifs-client@lists.samba.org Received: from mx2.redhat.com (mx2.redhat.com [66.187.237.31]) by lists.samba.org (Postfix) with ESMTP id 50EDD163BD3 for ; Wed, 10 Jun 2009 14:10:07 +0000 (GMT) Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5AEAbLa030137; Wed, 10 Jun 2009 10:10:37 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5AEAam7014121; Wed, 10 Jun 2009 10:10:37 -0400 Received: from tlielax.poochiereds.net (vpn-14-88.rdu.redhat.com [10.11.14.88]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5AEAZAD002496; Wed, 10 Jun 2009 10:10:36 -0400 Date: Wed, 10 Jun 2009 10:09:06 -0400 From: Jeff Layton To: smfrench@gmail.com Subject: Re: [linux-cifs-client] [PATCH] cifs: remove never-used in6_addr option Message-ID: <20090610100906.73b1b85b@tlielax.poochiereds.net> In-Reply-To: <1244642276-24398-1-git-send-email-jlayton@redhat.com> References: <1244642276-24398-1-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Cc: linux-cifs-client@lists.samba.org X-BeenThere: linux-cifs-client@lists.samba.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: The Linux CIFS VFS client List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cifs-client-bounces+patchwork-cifs-client=patchwork.kernel.org@lists.samba.org Errors-To: linux-cifs-client-bounces+patchwork-cifs-client=patchwork.kernel.org@lists.samba.org On Wed, 10 Jun 2009 09:57:54 -0400 Jeff Layton wrote: > This option was never used to my knowledge. Remove it before someone > does... > > Signed-off-by: Jeff Layton Oops, just realized that we can actually remove the in6_addr pointer from smb_vol as well. This patch should do that too. >From 04516c6e6b1f6e1ab6621afd872e0c8084465a86 Mon Sep 17 00:00:00 2001 From: Jeff Layton Date: Wed, 10 Jun 2009 10:04:58 -0400 Subject: [PATCH] cifs: remove never-used in6_addr option This option was never used to my knowledge. Remove it before someone does... Signed-off-by: Jeff Layton --- fs/cifs/connect.c | 11 ----------- 1 files changed, 0 insertions(+), 11 deletions(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 10151f8..fa50dc7 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -62,7 +62,6 @@ struct smb_vol { char *domainname; char *UNC; char *UNCip; - char *in6_addr; /* ipv6 address as human readable form of in6_addr */ char *iocharset; /* local code page for mapping to and from Unicode */ char source_rfc1001_name[16]; /* netbios name of client */ char target_rfc1001_name[16]; /* netbios name of server for Win9x/ME */ @@ -1319,16 +1318,6 @@ cifs_parse_mount_options(char *options, const char *devname, vol->direct_io = 1; } else if (strnicmp(data, "forcedirectio", 13) == 0) { vol->direct_io = 1; - } else if (strnicmp(data, "in6_addr", 8) == 0) { - if (!value || !*value) { - vol->in6_addr = NULL; - } else if (strnlen(value, 49) == 48) { - vol->in6_addr = value; - } else { - printk(KERN_WARNING "CIFS: ip v6 address not " - "48 characters long\n"); - return 1; - } } else if (strnicmp(data, "noac", 4) == 0) { printk(KERN_WARNING "CIFS: Mount option noac not " "supported. Instead set " -- 1.6.0.6