[linux-cifs-client] Fix losing locks during fork

Commit Message

Pavel Shilovsky April 21, 2010, 6:44 p.m. UTC

None

Patch

From: Pavel Shilovsky <[e-mail]>

[CIFS] Fix losing locks during fork()

When process does fork() private_data of files with lock list stays the same
for file descriptors of the parent and of the child. While finishing the child closes
files and deletes locks from the list even if unlocking fails. When the child process
finishes the parent doesn't have lock in lock list and can't unlock previously before
fork() locked region after the child process finished.

This patch provides behaviour to save locks in lock list if unlocking fails.

Signed-off-by: Pavel Shilovsky <[e-mail]>
Reviewed-by: Jeff Layton <[e-mail]>
---
 fs/cifs/file.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 9b11a8f..1f00d43 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -923,9 +923,10 @@  int cifs_lock(struct file *file, int cmd, struct file_lock *pfLock)
 							1, 0, li->type, false);
 					if (stored_rc)
 						rc = stored_rc;
-
-					list_del(&li->llist);
-					kfree(li);
+					else {
+						list_del(&li->llist);
+						kfree(li);
+					}
 				}
 			}
 			mutex_unlock(&fid->lock_mutex);
-- 
1.6.6.1