| Message ID | 20170202122117.1404479-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2017-02-02 4:21 GMT-08:00 Arnd Bergmann <arnd@arndb.de>: > This warning is harmless as size_t is always as wide as 'unsigned long': > > fs/cifs/smb2ops.c:2008:245: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t {aka unsigned int}' [-Werror=format=] > > Using %zu however is the correct format string that we don't get a warning for. > > Fixes: c9d651a5a2fe ("CIFS: Decrypt and process small encrypted packets") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > fs/cifs/smb2ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c > index 0764c32754b0..ac6e10adf000 100644 > --- a/fs/cifs/smb2ops.c > +++ b/fs/cifs/smb2ops.c > @@ -2005,7 +2005,7 @@ handle_read_data(struct TCP_Server_Info *server, struct mid_q_entry *mid, > rdata->iov[0].iov_len = 4; > rdata->iov[1].iov_base = buf + 4; > rdata->iov[1].iov_len = server->vals->read_rsp_size - 4; > - cifs_dbg(FYI, "0: iov_base=%p iov_len=%lu\n", > + cifs_dbg(FYI, "0: iov_base=%p iov_len=%zu\n", > rdata->iov[0].iov_base, server->vals->read_rsp_size); > > length = rdata->copy_into_pages(server, rdata, &iter); > -- > 2.9.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html This issue have been already fixed in the Steve's for-next branch. Thanks.
On Thu, 2017-02-02 at 13:21 +0100, Arnd Bergmann wrote: > This warning is harmless as size_t is always as wide as 'unsigned > long': > > fs/cifs/smb2ops.c:2008:245: error: format '%lu' expects argument of > type 'long unsigned int', but argument 5 has type 'size_t {aka > unsigned int}' [-Werror=format=] > > Using %zu however is the correct format string that we don't get a > warning for. > > Fixes: c9d651a5a2fe ("CIFS: Decrypt and process small encrypted > packets") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Sachin Prabhu <sprabhu@redhat.com> > --- > fs/cifs/smb2ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c > index 0764c32754b0..ac6e10adf000 100644 > --- a/fs/cifs/smb2ops.c > +++ b/fs/cifs/smb2ops.c > @@ -2005,7 +2005,7 @@ handle_read_data(struct TCP_Server_Info > *server, struct mid_q_entry *mid, > rdata->iov[0].iov_len = 4; > rdata->iov[1].iov_base = buf + 4; > rdata->iov[1].iov_len = server->vals->read_rsp_size - 4; > - cifs_dbg(FYI, "0: iov_base=%p iov_len=%lu\n", > + cifs_dbg(FYI, "0: iov_base=%p iov_len=%zu\n", > rdata->iov[0].iov_base, server->vals- > >read_rsp_size); > > length = rdata->copy_into_pages(server, rdata, &iter); -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index 0764c32754b0..ac6e10adf000 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -2005,7 +2005,7 @@ handle_read_data(struct TCP_Server_Info *server, struct mid_q_entry *mid, rdata->iov[0].iov_len = 4; rdata->iov[1].iov_base = buf + 4; rdata->iov[1].iov_len = server->vals->read_rsp_size - 4; - cifs_dbg(FYI, "0: iov_base=%p iov_len=%lu\n", + cifs_dbg(FYI, "0: iov_base=%p iov_len=%zu\n", rdata->iov[0].iov_base, server->vals->read_rsp_size); length = rdata->copy_into_pages(server, rdata, &iter);
This warning is harmless as size_t is always as wide as 'unsigned long': fs/cifs/smb2ops.c:2008:245: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t {aka unsigned int}' [-Werror=format=] Using %zu however is the correct format string that we don't get a warning for. Fixes: c9d651a5a2fe ("CIFS: Decrypt and process small encrypted packets") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- fs/cifs/smb2ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)