diff mbox

fix alloc_cast.cocci warnings

Message ID 20170305224241.GA108280@athens.lkp.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fengguang Wu March 5, 2017, 10:42 p.m. UTC
fs/cifs/smb2misc.c:689:14-41: WARNING: casting value returned by memory allocation function to (struct close_cancelled_open *) is useless.

 Remove casting the values returned by memory allocation functions
 like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc.

Semantic patch information:
 This makes an effort to find cases of casting of values returned by
 kmalloc, kzalloc, kcalloc, kmem_cache_alloc, kmem_cache_zalloc,
 kmem_cache_alloc_node, kmalloc_node and kzalloc_node and removes
 the casting as it is not required. The result in the patch case may
need some reformatting.

Generated by: scripts/coccinelle/api/alloc/alloc_cast.cocci

CC: Sachin Prabhu <sprabhu@redhat.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 smb2misc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/fs/cifs/smb2misc.c
+++ b/fs/cifs/smb2misc.c
@@ -686,7 +686,7 @@  smb2_handle_cancelled_mid(char *buffer,
 		(sync_hdr->Status != STATUS_SUCCESS))
 		return 0;
 
-	cancelled = (struct close_cancelled_open *)
+	cancelled =
 			kzalloc(sizeof(struct close_cancelled_open),
 				GFP_KERNEL);
 	if (!cancelled)