| Message ID | 20170424132259.8680-10-jlayton@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Apr 24, 2017 at 09:22:48AM -0400, Jeff Layton wrote: > launder_page is just writeback under the page lock. We still need to > mark the mapping for errors there when they occur. > > Signed-off-by: Jeff Layton <jlayton@redhat.com> Looks fine, Reviewed-by: Christoph Hellwig <hch@lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon 24-04-17 09:22:48, Jeff Layton wrote: > launder_page is just writeback under the page lock. We still need to > mark the mapping for errors there when they occur. > > Signed-off-by: Jeff Layton <jlayton@redhat.com> Looks good. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/9p/vfs_addr.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/9p/vfs_addr.c b/fs/9p/vfs_addr.c > index adaf6f6dd858..7af6e6501698 100644 > --- a/fs/9p/vfs_addr.c > +++ b/fs/9p/vfs_addr.c > @@ -223,8 +223,11 @@ static int v9fs_launder_page(struct page *page) > v9fs_fscache_wait_on_page_write(inode, page); > if (clear_page_dirty_for_io(page)) { > retval = v9fs_vfs_writepage_locked(page); > - if (retval) > + if (retval) { > + if (retval != -EAGAIN) > + mapping_set_error(page->mapping, retval); > return retval; > + } > } > return 0; > } > -- > 2.9.3 > >
diff --git a/fs/9p/vfs_addr.c b/fs/9p/vfs_addr.c index adaf6f6dd858..7af6e6501698 100644 --- a/fs/9p/vfs_addr.c +++ b/fs/9p/vfs_addr.c @@ -223,8 +223,11 @@ static int v9fs_launder_page(struct page *page) v9fs_fscache_wait_on_page_write(inode, page); if (clear_page_dirty_for_io(page)) { retval = v9fs_vfs_writepage_locked(page); - if (retval) + if (retval) { + if (retval != -EAGAIN) + mapping_set_error(page->mapping, retval); return retval; + } } return 0; }
launder_page is just writeback under the page lock. We still need to mark the mapping for errors there when they occur. Signed-off-by: Jeff Layton <jlayton@redhat.com> --- fs/9p/vfs_addr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)