Message ID | 20170505053040.x67a5f4riyba2wqb@mwanda (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
merged into cifs-2.6.git for-next On Fri, May 5, 2017 at 12:30 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > The current code causes a static checker warning because ITER_IOVEC is > zero so the condition is never true. > > Fixes: 6685c5e2d1ac ("CIFS: Add asynchronous read support through kernel AIO") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > I'm assuming this is the correct fix from looking at how ITER_IOVEC is > normally used. Please review. > > diff --git a/fs/cifs/file.c b/fs/cifs/file.c > index 6ef78ad838e6..71ba8fa63c41 100644 > --- a/fs/cifs/file.c > +++ b/fs/cifs/file.c > @@ -3271,7 +3271,7 @@ ssize_t cifs_user_readv(struct kiocb *iocb, struct iov_iter *to) > if (!is_sync_kiocb(iocb)) > ctx->iocb = iocb; > > - if (to->type & ITER_IOVEC) > + if (to->type == ITER_IOVEC) > ctx->should_dirty = true; > > rc = setup_aio_ctx_iter(ctx, to, READ); > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 6ef78ad838e6..71ba8fa63c41 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -3271,7 +3271,7 @@ ssize_t cifs_user_readv(struct kiocb *iocb, struct iov_iter *to) if (!is_sync_kiocb(iocb)) ctx->iocb = iocb; - if (to->type & ITER_IOVEC) + if (to->type == ITER_IOVEC) ctx->should_dirty = true; rc = setup_aio_ctx_iter(ctx, to, READ);
The current code causes a static checker warning because ITER_IOVEC is zero so the condition is never true. Fixes: 6685c5e2d1ac ("CIFS: Add asynchronous read support through kernel AIO") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- I'm assuming this is the correct fix from looking at how ITER_IOVEC is normally used. Please review. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html