| Message ID | 20170829192915.26251-12-longli@exchange.microsoft.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2017-08-29 12:29 GMT-07:00 Long Li <longli@exchange.microsoft.com>: > From: Long Li <longli@microsoft.com> > > To prepare for RDMA read/write using memory registration, add memory > registartion pointers to upper layer data I/O context. > > Signed-off-by: Long Li <longli@microsoft.com> > --- > fs/cifs/cifsglob.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h > index dc5404d..dcd2b63 100644 > --- a/fs/cifs/cifsglob.h > +++ b/fs/cifs/cifsglob.h > @@ -1166,6 +1166,7 @@ struct cifs_readdata { > struct cifs_readdata *rdata, > struct iov_iter *iter); > struct kvec iov[2]; > + struct smbd_mr *mr; > unsigned int pagesz; > unsigned int tailsz; > unsigned int credits; > @@ -1188,6 +1189,7 @@ struct cifs_writedata { > pid_t pid; > unsigned int bytes; > int result; > + struct smbd_mr *mr; > unsigned int pagesz; > unsigned int tailsz; > unsigned int credits; > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html The same thing: let's not add structure fields that the code doesn't do anything with. -- Best regards, Pavel Shilovsky -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Pavel Shilovsky [mailto:piastryyy@gmail.com] > Sent: Tuesday, August 29, 2017 5:49 PM > To: Long Li <longli@microsoft.com> > Cc: Steve French <sfrench@samba.org>; linux-cifs <linux- > cifs@vger.kernel.org>; samba-technical <samba-technical@lists.samba.org>; > Kernel Mailing List <linux-kernel@vger.kernel.org>; linux- > rdma@vger.kernel.org; Christoph Hellwig <hch@infradead.org>; Tom Talpey > <ttalpey@microsoft.com>; Matthew Wilcox <mawilcox@microsoft.com>; > Long Li <longli@microsoft.com> > Subject: Re: [Patch v3 11/19] CIFS: SMBD: Define memory registration for I/O > data > > 2017-08-29 12:29 GMT-07:00 Long Li <longli@exchange.microsoft.com>: > > From: Long Li <longli@microsoft.com> > > > > To prepare for RDMA read/write using memory registration, add memory > > registartion pointers to upper layer data I/O context. > > > > Signed-off-by: Long Li <longli@microsoft.com> > > --- > > fs/cifs/cifsglob.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h index > > dc5404d..dcd2b63 100644 > > --- a/fs/cifs/cifsglob.h > > +++ b/fs/cifs/cifsglob.h > > @@ -1166,6 +1166,7 @@ struct cifs_readdata { > > struct cifs_readdata *rdata, > > struct iov_iter *iter); > > struct kvec iov[2]; > > + struct smbd_mr *mr; > > unsigned int pagesz; > > unsigned int tailsz; > > unsigned int credits; > > @@ -1188,6 +1189,7 @@ struct cifs_writedata { > > pid_t pid; > > unsigned int bytes; > > int result; > > + struct smbd_mr *mr; > > unsigned int pagesz; > > unsigned int tailsz; > > unsigned int credits; > > -- > > 2.7.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-cifs" > > in the body of a message to majordomo@vger.kernel.org More > majordomo > > info at > > > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.k > > ernel.org%2Fmajordomo- > info.html&data=02%7C01%7Clongli%40microsoft.com% > > > 7C1a02c615906e4648835c08d4ef40e655%7C72f988bf86f141af91ab2d7cd011d > b47% > > > 7C1%7C0%7C636396509394018449&sdata=yjvt3xPYPMmBp8nRiAC%2FYUOOs > ganvPd%2 > > Ff6Y1uZtbqGU%3D&reserved=0 > > The same thing: let's not add structure fields that the code doesn't do > anything with. Okay. I will fold the patch into relevant patches. > > -- > Best regards, > Pavel Shilovsky
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h index dc5404d..dcd2b63 100644 --- a/fs/cifs/cifsglob.h +++ b/fs/cifs/cifsglob.h @@ -1166,6 +1166,7 @@ struct cifs_readdata { struct cifs_readdata *rdata, struct iov_iter *iter); struct kvec iov[2]; + struct smbd_mr *mr; unsigned int pagesz; unsigned int tailsz; unsigned int credits; @@ -1188,6 +1189,7 @@ struct cifs_writedata { pid_t pid; unsigned int bytes; int result; + struct smbd_mr *mr; unsigned int pagesz; unsigned int tailsz; unsigned int credits;