diff mbox

CIFS: decrease log level of smb2 DFS error

Message ID 20171121111429.14496-1-aaptel@suse.com (mailing list archive)
State New, archived
Headers show

Commit Message

Aurélien Aptel Nov. 21, 2017, 11:14 a.m. UTC 
Signed-off-by: Aurelien Aptel <aaptel@suse.com>
---
 fs/cifs/smb2ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

ronnie sahlberg Nov. 21, 2017, 11:22 a.m. UTC | #1 
Since in 99.999999% times happens just because "it is a real share",
we could optionally change it instead to be wrapped in :

if (rc != <whatever STATUS_NOT_FOUND maps to>)
     cifs_dbg(VFS, log the error message

so that we do not log anything if it is just a normal share
but that we do log something if there is a real error.




On Tue, Nov 21, 2017 at 9:14 PM, Aurelien Aptel <aaptel@suse.com> wrote:
> Signed-off-by: Aurelien Aptel <aaptel@suse.com>
> ---
>  fs/cifs/smb2ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> index 0dafdbae1f8c..59d18a7d550d 100644
> --- a/fs/cifs/smb2ops.c
> +++ b/fs/cifs/smb2ops.c
> @@ -1387,7 +1387,7 @@ smb2_get_dfs_refer(const unsigned int xid, struct cifs_ses *ses,
>         } while (rc == -EAGAIN);
>
>         if (rc) {
> -               cifs_dbg(VFS, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
> +               cifs_dbg(FYI, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
>                 goto out;
>         }
>
> --
> 2.12.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Aurélien Aptel Nov. 21, 2017, 1:48 p.m. UTC | #2 
ronnie sahlberg <ronniesahlberg@gmail.com> writes:
> Since in 99.999999% times happens just because "it is a real share",
> we could optionally change it instead to be wrapped in :
>
> if (rc != <whatever STATUS_NOT_FOUND maps to>)
>      cifs_dbg(VFS, log the error message
>
> so that we do not log anything if it is just a normal share
> but that we do log something if there is a real error.

Good idea
diff mbox

Patch

diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index 0dafdbae1f8c..59d18a7d550d 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -1387,7 +1387,7 @@  smb2_get_dfs_refer(const unsigned int xid, struct cifs_ses *ses,
 	} while (rc == -EAGAIN);
 
 	if (rc) {
-		cifs_dbg(VFS, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
+		cifs_dbg(FYI, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
 		goto out;
 	}